Fix green joker simulation crash when extra field is indexed as table #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base game's simulation code at card.lua:6801 attempts to index the 'extra' field as a table, but Cryptid's green_joker override sets extra to a number (1). This causes a crash: 'attempt to index field 'extra' (a number value)'. This fix adds a simulate function that: - Normalizes the extra field to a number before simulation - Handles cases where extra might be a table or nil - Returns proper simulation results so the base code doesn't need to access extra directly Fixes crash when simulating Green Joker effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The base game's simulation code at
card.lua:6801attempts to index the 'extra' field as a table, but Cryptid's green_joker override sets extra to a number (1). This causes a crash:Solution
This fix adds a
simulatefunction to the green_joker override that:Testing
Tested in multiplayer game - no crashes when simulating Green Joker effects.
Fixes the crash reported in issue where Green Joker causes game to crash during simulation.