refactor(PZ): Replace GetTieringParameters with dogtags BED-6938

[kpom-specter]

• Add NewTestService helper for configurable test overrides
• Update UpdateAssetGroupTag to use DogTags.GetFlagAsBool
• Update tests to use NewTestService with appropriate overrides

Description

Describe your changes in detail

Motivation and Context

Resolves <TICKET_OR_ISSUE_NUMBER>

Why is this change required? What problem does it solve?

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (optional):

Types of changes

• Chore (a change that does not modify the application functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Database Migrations

Checklist:

• I have met the contributing prerequisites
  • Assigned myself to this PR
  • Added the appropriate labels
  • Associated an issue: Issues and Pull Requests README #672
  • Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
• I have ensured that related documentation is up-to-date
  • Open API docs
  • Code comments (GoDocs / JSDocs)
• I have followed proper test practices
  • Added/updated tests to cover my changes
  • All new and existing tests passed

Summary by CodeRabbit

• Refactor

  • Centralized feature-flag handling moved to a dedicated dogtags service, updating how multi-tier analysis is evaluated.

• Tests

  • Test infrastructure enhanced with a configurable dogtags test service and updated tests to use it.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Replaced a tiering-parameter multi-tier analysis check with the DogTags feature-flag in UpdateAssetGroupTag and wired a testable DogTags service into asset group tag tests; added a test Service implementation and overrides for dogtags.

Changes

Cohort / File(s)	Summary
API Endpoint Update cmd/api/src/api/v2/assetgrouptags.go	Added dogtags import and replaced appcfg.GetTieringParameters(...).MultiTierAnalysisEnabled with s.DogTags.GetFlagAsBool(dogtags.PZ_MULTI_TIER_ANALYSIS) in UpdateAssetGroupTag.
Test Fixtures & Wiring cmd/api/src/api/v2/assetgrouptags_test.go	Added DogTags dogtags.Service to test Resources and initialized it via dogtags.NewDefaultService() or dogtags.NewTestService(...) across many asset-group-tag tests.
DogTags Service Extensions cmd/api/src/services/dogtags/service.go	Introduced TestOverrides and NewTestService(overrides) returning an internal testService with override-aware methods (GetFlagAsBool, GetFlagAsInt, GetFlagAsString, GetAllDogTags) for testing.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat(dogtags): Adds DogTags functionality for SKU Flagging BED-5560 #2147 — Adds and wires dogtags service/flags and contains overlapping dogtags test wiring changes.
• refactor: Added Unit tests for AssetGroupTags BED-6873 #2119 — Related changes to AssetGroupTags test setup and config-key adjustments used by these tests.

Suggested labels

api, enhancement

Suggested reviewers

• irshadaj
• mistahj67
• seanjSO

Poem

🐰 I nibbled flags beneath the moon,
Wired DogTags quick — a clever tune,
Tests now hop with overrides bright,
Tiering's check replaced tonight,
Code hops forward, tails in flight! 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description includes initial bullet points summarizing changes but fails to complete required template sections. Critical fields like 'Description,' 'Motivation and Context,' and 'How Has This Been Tested' contain only placeholder text or are left empty, violating the repository's contribution requirements.	Complete all required template sections: replace placeholder text in Description, Motivation and Context, and How Has This Been Tested; confirm checklist items are properly addressed; ensure the associated Jira ticket BED-6938 is explicitly mentioned in the Motivation section.
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: replacing GetTieringParameters with dogtags for multi-tier analysis flagging, directly matching the refactoring shown in the code changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@cmd/api/src/services/dogtags/service.go`:
- Around line 39-83: testService.GetAllDogTags currently only adds bool and int
tags; update it to also iterate AllStringDogTags and add those entries using
s.GetFlagAsString(key) so testService mirrors the production service; locate the
method testService.GetAllDogTags and append a loop over AllStringDogTags that
sets result[string(key)] = s.GetFlagAsString(key).