Skip to content

Conversation

@rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Jan 22, 2026

https://specterops.atlassian.net/browse/BED-7200

AZOwner to devices is a confirmed false positive with no actual impact. Removing collection of this edge entirely.

Summary by CodeRabbit

  • Deprecations
    • Removed device owners functionality from Azure AD reporting capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Walkthrough

This pull request removes the device owners listing feature from the codebase, including the CLI command implementation, related test file, enum constant, and references to the device owners computation in the main aggregation pipeline.

Changes

Cohort / File(s) Summary
Command Implementation Removal
cmd/list-device-owners.go
Deleted entire command file (131 lines) that implemented Azure AD device owners enumeration with context management, concurrent streaming, Graph API queries, error handling, and structured output.
Main Aggregation Logic
cmd/list-azure-ad.go
Removed deviceOwners variable computation from the devices pipeline and its argument from the pipeline.Mux call (2 lines deleted).
Enum Constant
enums/kind.go
Removed public constant KindAZDeviceOwner representing "AZDeviceOwner" from the Kind string enum (1 line deleted).
Test Coverage
cmd/list-device-owners_test.go
Deleted entire test file (102 lines) containing license header, mock setup, mock data feeding goroutines, consumer validation, and TestListDeviceOwners test logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Device owners hop away to the warren,
No more querying Azure's domain—
Simpler streams, lighter loads remain,
The code now sleek, the feature gone,
A cleaner burrow to dance upon! 🌿✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removal of Azure device owner collection. It is specific, clear, and directly reflects the changeset's primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants