Repository navigation
chore!: bump Forge to v8 - #24
SpacingBat3 wants to merge 6 commits into
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
94c1968 to
7365d10
Compare
d8df0c4 to
4244b87
Compare
42c93f9 to
8a6fd2a
Compare
8a6fd2a to
d36952c
Compare
As Forge has specialized some types, this adapts ReForged types to make them compatible with the Forge changes.
|
Sorry for the random comment, but a friendly notice that Forge v8 has been released (although lacking in documentation it seems...) |
|
Yeah, I've seen it, I just didn't have time to consolidate changes there on repo and switch to stable releases to ensure nothing breaking was introduced. Also:
Just to clear things out since I was contributing towards Forge for the docs, the new docs are there, just the links to docs are broken since their CI script just merges the old docs and new ones changed due to Typedoc update in Forge 8. I saw other PR being involved in some doc switch to docsaurus so things on doc front are I think still WIP, there might not be code that releases new manually-written doc pages but dynamic ones at https://js.electronforge.io/ should already be deployed. |
Important
The current patchset is for testing purposes only and will most likely be fully rebased once Electron Forge v8.0.0 will be released. Please bear that in mind this means a like-hood of doing a force push (this branch, not
master)!For that reason, this PR will remain draft until everything will be in-place to work on releasing it.
This patchset aims to bump Forge to v8 and eventually fix any major breakages on the way.
Checklist
maker-appimageonly), both remotely and locally.example), additionally validating initial development stage components (plugin-launcher).Confirm everything stays backwards-compatible (it'll probably stay if there are no code changes necessary) and plan strategy for backwards-incompatible API.Edit: PR is marked as breaking due to Forge types incompatibilities – this needs to be reflected inpackage.jsonto depend only on newer Forge version.Related
Upstream issue ticket: electron/forge#4082