Skip to content

Feat improve list ruin#46

Merged
blackopsrepl merged 2 commits into
SolverForge:mainfrom
NewBornRustacean:feat-improve-list-ruin
Apr 26, 2026
Merged

Feat improve list ruin#46
blackopsrepl merged 2 commits into
SolverForge:mainfrom
NewBornRustacean:feat-improve-list-ruin

Conversation

@NewBornRustacean
Copy link
Copy Markdown
Contributor

@NewBornRustacean NewBornRustacean commented Apr 25, 2026

closes #45

Summary

Fixes ListRuinMoveSelector so empty routes no longer consume moves_per_step sampling attempts. Previously, the selector sampled from all entities and dropped attempts that selected an empty route. This could make the selector yield fewer ruin moves than configured when the solution contained empty routes.

Changes

  • Sample ruin moves from (entity_index, list_length) pairs where list_length > 0.
  • Add regression coverage verifying that empty routes do not reduce the number of yielded moves when at least one non-empty route exists.

@NewBornRustacean NewBornRustacean marked this pull request as ready for review April 25, 2026 23:58
@NewBornRustacean
Copy link
Copy Markdown
Contributor Author

note:
existing failure - some macro related tests fails. 😿

@blackopsrepl
Copy link
Copy Markdown
Collaborator

note: existing failure - some macro related tests fails. 😿

No issue - that was just the CI hanging for some reason. I reran it and it's green. Thank you!

@blackopsrepl blackopsrepl merged commit 5bf5fbb into SolverForge:main Apr 26, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ListRuinMoveSelector can yield fewer moves than its original setup

2 participants