Skip to content

Fix Clippy CI warnings for 0.8.7 solver route builders #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blackopsrepl merged 2 commits into from
Apr 17, 2026
Merged

Fix Clippy CI warnings for 0.8.7 solver route builders #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99da848
Fix clippy warnings in solver route builders
blackopsrepl Apr 17, 2026
de3937b
Fix rustfmt CI failure in Clarke-Wright loop
blackopsrepl Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/solverforge-solver/src/heuristic/move/list_ruin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ where
Actually: after k insertions at positions orig_indices[0..k] (all <= orig_indices[k]
since sorted), orig_indices[k]'s effective position has shifted by k.
*/
for (&idx, val) in orig_indices.iter().zip(vals.into_iter()) {
for (&idx, val) in orig_indices.iter().zip(vals) {
list_insert(s, orig_entity, idx, val);
}
}));
Expand Down
9 changes: 3 additions & 6 deletions crates/solverforge-solver/src/manager/phase_factory/list_clarke_wright.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ where
}
}
}
savings.sort_unstable_by(|a, b| b.0.cmp(&a.0));
savings.sort_unstable_by_key(|entry| std::cmp::Reverse(entry.0));

// Greedy merge
for (merge_idx, (_, i, j)) in savings.iter().enumerate() {
Expand Down Expand Up @@ -337,7 +337,7 @@ where
}
let candidate_route: Vec<usize> = test_ri
.into_iter()
.chain(test_rj.into_iter())
.chain(test_rj)
.map(|idx| index_to_element(solution, idx).into())
.collect();
if !feasible(solution, &candidate_route) {
Expand Down Expand Up @@ -387,10 +387,7 @@ where

{
let sd = step_scope.score_director_mut();
for (entity_idx, index_route) in available_entity_slots
.into_iter()
.zip(non_empty.into_iter())
{
for (entity_idx, index_route) in available_entity_slots.into_iter().zip(non_empty) {
sd.before_variable_changed(descriptor_index, entity_idx);
let element_route: Vec<E> = index_route
.iter()
Expand Down
Loading