Feature/error handling #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added logging configuration to capture detailed information. * Improved error handling for file operations and EQ band parsing. * Updated main application logic to log parsing steps and results. * Enhanced user feedback for EQ settings application process.
…ply_eq` * Added specific error logging for connection timeouts and client connection errors. * Adjusted timeout parameter from 10 to 5 seconds for better responsiveness. * Enhanced logging suppression for `aiohttp` and `aiostreammagic` to reduce noise.
- Changed logging levels for `aiohttp`, `aiostreammagic`, and `asyncio` to `CRITICAL` to suppress unnecessary debug logs. - Added `ServerTimeoutError` import for potential future error handling in `connect_and_apply_eq`.
…larity * Simplified the connection and EQ application process in `connect_and_apply_eq`. * Removed nested try-except blocks for better readability. * Enhanced logging for connection status and device information.
… EQ settings * Ensure proper disconnection from the StreamMagic device. * Log the disconnection event for better traceability.
* Incremented the version number in `pyproject.toml` to reflect the latest changes.
* Updated `main` function to accept parameters directly instead of relying on `sys.argv`. * Enhanced error handling by returning error codes instead of using `sys.exit`. * Improved clarity and maintainability of the code.
- Introduced `argparse` for improved command line interface. - Added options for `--host`, `--timeout`, and `--dry-run`. - Enhanced user experience with usage examples and default values.
* Implemented validation for both IPv4 and IPv6 addresses in `connect_and_apply_eq`. * Added error logging for invalid IP addresses to improve debugging.
- Clarified that the tool sends EQ settings to the StreamMagic device at the specified host IP address. - Added details on using the `--host` argument for setting the host IP address. - Included information about IP address validation before connection. - Documented the `--dry-run` option for parsing files without connecting to the device. - Explained how to set the connection timeout duration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.