Skip to content

Updates to remove JMS references and replace with Jakarta Messaging - #188

Closed
HariRangarajan-Solace wants to merge 8 commits into
masterfrom
feature/update-jms-to-jakarta
Closed

HariRangarajan-Solace wants to merge 8 commits into
masterfrom
feature/update-jms-to-jakarta

Conversation

@HariRangarajan-Solace

Copy link
Copy Markdown
Contributor

Changes include :

  • Updates to remove JMS references.
  • Replace JMS with Jakarta messaging
  • Update references to new code repository and sample paths.

Copilot AI balanced review requested due to automatic review settings September 29, 2026 13:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The shared API fragment breaks non-JMS tutorials, and the delivery documentation incorrectly excludes asynchronous sends.

Review effort: Balanced
Findings: 1 High severity · 2 Medium severity · 1 Low severity

Open (4)
What changed in this PR

Migrates JMS tutorials and sample references to Jakarta Messaging 3.1.

Changes:

  • Updates terminology, documentation links, and sample paths.
  • Points tutorials to the Jakarta Messaging sample repository.
  • Adds Gradle and Maven dependency instructions.
File Description
using-jndi.md Updates JNDI terminology and sample links.
using-external-jndi.md Migrates external JNDI guidance and links.
tutorials.yml Renames the tutorial collection and repository.
topic-to-queue-mapping.md Updates Jakarta Messaging terminology.
request-reply.md Migrates request/reply documentation and samples.
publish-subscribe.md Updates API references and sample instructions.
persistence-with-queues.md Migrates persistent messaging guidance.
confirmed-delivery.md Updates delivery confirmation documentation.
common-assets/​solaceApi.md Adds Jakarta JMS dependency instructions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/pages/tutorials/common-assets/solaceApi.md Outdated
Comment thread src/pages/tutorials/jms/confirmed-delivery.md
Comment thread src/pages/tutorials/jms/persistence-with-queues.md Outdated
Comment thread src/pages/tutorials/jms/request-reply.md

@Mrc0113 Mrc0113 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge to me. Let's await product review to make sure the naming is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants