Skip to content

Restore missing title on solace-rabbit-shovel codelab - #408

Merged
Mrc0113 merged 1 commit into
masterfrom
fix/rabbit-shovel-title
Sep 18, 2026
Merged

Mrc0113 merged 1 commit into
masterfrom
fix/rabbit-shovel-title

Conversation

@Mrc0113

@Mrc0113 Mrc0113 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Problem

The solace-rabbit-shovel codelab renders with no title in the top bar.

The generated index.html has an empty <title></title> and <google-codelab title="">. The <google-codelab title=...> attribute is what the JS renders into the title bar, so an empty value = no title shown. (The landing-page card still shows the title because that comes from codelab.json, which is correct.)

Root cause

Commit 5e20516 ("modify info boxes (#251)") blanked the title attribute in this file:

- title="Bridge data from RabbitMQ to Solace PubSub&#43;"
+ title=""

Because this codelab has no markdown source in the repo, claat never regenerated it, so the blank title was never restored.

Fix

Restore both the <title> and the <google-codelab title=...> from the authoritative codelab.json value ("Bridge data from RabbitMQ to Solace PubSub+"), matching claat's original HTML-entity encoding (&#43; for the trailing +). Two lines; direct HTML edit since there is no markdown to regenerate from.

Verify after deploy

Open https://codelabs.solace.dev/codelabs/solace-rabbit-shovel/ — the title "Bridge data from RabbitMQ to Solace PubSub+" now appears in the top bar and browser tab.

🤖 Generated with Claude Code

The generated index.html had an empty <title></title> and
<google-codelab title="">, so the codelab rendered with no title in the top
bar. Commit 5e20516 ("modify info boxes (#251)") blanked the title
attribute; because this codelab has no markdown source in the repo, claat
never regenerated it to restore the value.

Restore the title from the authoritative codelab.json
("Bridge data from RabbitMQ to Solace PubSub+"), matching claat's original
HTML-entity encoding for the trailing '+'.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@solacecommunity-bot

Copy link
Copy Markdown
Collaborator

Thanks for opening up a PR and contributing to our open source codelabs!

Review process Guidelines

Once the PR is opened, tag at least one Technical Reviewer

Technical Reviewer Responsibilities

  • Dry-run technical steps
  • Review technical positioning/messaging
  • Point out typos and potential formatting issues
  • Technical Reviewer(s): "Approve" or "Request Changes" by navigating to the Files changed tab and click on the "Review Changes" drop down
    Review Changes button

Post Technical Review

A member of the Developer Advocate Team will review overall structure and merge into master which will push it to production

@Mrc0113

Mrc0113 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

Admin-merging: same deadlock as #407 — master requires the Build_Preview check, but its workflow (netlify.yml) is path-filtered to markdown/** and never fires for a codelabs-only change. The two checks that can run both passed. Deploy still needs a submodule bump in solace-dev-codelabs-site.

@Mrc0113
Mrc0113 merged commit dabcd4e into master Sep 18, 2026
2 checks passed
@Mrc0113
Mrc0113 deleted the fix/rabbit-shovel-title branch September 18, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants