Restore missing title on solace-rabbit-shovel codelab - #408
Merged
Merged
Conversation
The generated index.html had an empty <title></title> and <google-codelab title="">, so the codelab rendered with no title in the top bar. Commit 5e20516 ("modify info boxes (#251)") blanked the title attribute; because this codelab has no markdown source in the repo, claat never regenerated it to restore the value. Restore the title from the authoritative codelab.json ("Bridge data from RabbitMQ to Solace PubSub+"), matching claat's original HTML-entity encoding for the trailing '+'. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Collaborator
Author
|
Admin-merging: same deadlock as #407 — master requires the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The solace-rabbit-shovel codelab renders with no title in the top bar.
The generated
index.htmlhas an empty<title></title>and<google-codelab title="">. The<google-codelab title=...>attribute is what the JS renders into the title bar, so an empty value = no title shown. (The landing-page card still shows the title because that comes fromcodelab.json, which is correct.)Root cause
Commit
5e20516("modify info boxes (#251)") blanked the title attribute in this file:Because this codelab has no markdown source in the repo, claat never regenerated it, so the blank title was never restored.
Fix
Restore both the
<title>and the<google-codelab title=...>from the authoritativecodelab.jsonvalue ("Bridge data from RabbitMQ to Solace PubSub+"), matching claat's original HTML-entity encoding (+for the trailing+). Two lines; direct HTML edit since there is no markdown to regenerate from.Verify after deploy
Open https://codelabs.solace.dev/codelabs/solace-rabbit-shovel/ — the title "Bridge data from RabbitMQ to Solace PubSub+" now appears in the top bar and browser tab.
🤖 Generated with Claude Code