Fix queries classified as Unknown statement type by updating parsing dialect=snowflake#170
Merged
sfc-gh-twhite merged 1 commit intoApr 1, 2026
Conversation
sfc-gh-twhite
approved these changes
Apr 1, 2026
This was referenced Apr 1, 2026
|
Looks like pre-commit failed, can we get that fixed so this can be relased. Thanks @sfc-gh-twhite |
This was referenced Apr 1, 2026
elipollak
added a commit
to elipollak/mcp
that referenced
this pull request
Apr 2, 2026
…t test coverage Add tests for Snowflake-specific syntax not covered by Snowflake-Labs#170: COPY INTO, LATERAL FLATTEN, nested dot-path notation, bracket notation, OBJECT_CONSTRUCT, and GET_PATH. Also add Copy to the README permissions example so users can configure it explicitly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
elipollak
added a commit
to elipollak/mcp
that referenced
this pull request
Apr 2, 2026
…t test coverage Add tests for Snowflake-specific syntax not covered by Snowflake-Labs#170: COPY INTO, LATERAL FLATTEN, nested dot-path notation, bracket notation, OBJECT_CONSTRUCT, and GET_PATH. Also add Copy to the README permissions example so users can configure it explicitly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
elipollak
added a commit
to elipollak/mcp
that referenced
this pull request
Apr 2, 2026
…t test coverage Add tests for Snowflake-specific syntax not covered by Snowflake-Labs#170: COPY INTO, LATERAL FLATTEN, nested dot-path notation, bracket notation, OBJECT_CONSTRUCT, and GET_PATH. Also add Copy to the README permissions example so users can configure it explicitly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sfc-gh-twhite
pushed a commit
that referenced
this pull request
Apr 2, 2026
…t test coverage (#173) Add tests for Snowflake-specific syntax not covered by #170: COPY INTO, LATERAL FLATTEN, nested dot-path notation, bracket notation, OBJECT_CONSTRUCT, and GET_PATH. Also add Copy to the README permissions example so users can configure it explicitly. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlglot.parse_one()was called without a dialect, so Snowflake's::typecast syntax caused aParseError. This resulted in queries using colon-path access with a cast (e.g.v:key::string) being classified asUnknownand rejected bysql_statement_permissions, even whenSelectwas explicitly allowed.Fix: pass in
dialect="snowflake"