Migrate RESOURCE_CONFIG_PATH env var to GIGL_RESOURCE_CONFIG_URI#648
Draft
kmontemayor2-sc wants to merge 1 commit into
Draft
Migrate RESOURCE_CONFIG_PATH env var to GIGL_RESOURCE_CONFIG_URI#648kmontemayor2-sc wants to merge 1 commit into
kmontemayor2-sc wants to merge 1 commit into
Conversation
Aligns the resource-config env var with the GIGL_* convention introduced in #642 and the existing GIGL_RESOURCE_CONFIG_URI_ENV_KEY constant. All writers (get_resource_config, launch_graph_store_local.py, Makefile's notebooks_test target) now set the new name; readers fall back to the deprecated RESOURCE_CONFIG_PATH with a one-time warning so externally-set values keep working for one release cycle. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the resource-config env var with the GIGL_* convention introduced in #642 and the existing GIGL_RESOURCE_CONFIG_URI_ENV_KEY constant. All writers (get_resource_config, launch_graph_store_local.py, Makefile's notebooks_test target) now set the new name; readers fall back to the deprecated RESOURCE_CONFIG_PATH with a one-time warning so externally-set values keep working for one release cycle.
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO