Fix latent bugs surfaced by ty migration#646
Merged
Merged
Conversation
Resolves 4 `# ty: ignore` comments from PR #585 by fixing the underlying logic (not suppressing). Includes None-division risk in loss.py and masked None flow in optimizer code paths. See: docs/plans/20260518-ty-ignore-resolution-meta.md
The repo's default unit-test pattern is *_test.py (Makefile:29, tests/unit/main.py:8); the original name test_torchrec_utils.py uses the prefix form, so the new regression coverage for apply_sparse_optimizer would be silently skipped by make unit_test_py / CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 17:55:04UTC : 🔄 @ 19:24:40UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:55:05UTC : 🔄 @ 18:04:08UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:55:06UTC : 🔄 @ 17:57:02UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:55:07UTC : 🔄 @ 19:19:34UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:55:07UTC : 🔄 @ 18:04:07UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:55:07UTC : 🔄 @ 18:53:11UTC : ✅ Workflow completed successfully. |
svij-sc
reviewed
May 19, 2026
- Consolidate SoftmaxLoss regression coverage into the existing loss_test.py (one assertion on the default temperature). - Delete legacy_loss_test.py (was a misnamed parallel file created to avoid clobbering the existing loss_test.py). - Trim torchrec_utils_test.py from 4 tests to 1 — the actual regression path (defaults flowing through to RowWiseAdagrad). - Drop test-side narrative docstrings that re-described what the fix did rather than the contract under test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
svij-sc
approved these changes
May 20, 2026
yliu2-sc
approved these changes
May 20, 2026
kmontemayor2-sc
requested review from
mkolodner-sc,
xgao4-sc and
zfan3-sc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 4
# ty: ignorecomments from PR #585 by fixing the underlying logic (not suppressing). Includes None-division risk in loss.py and masked None flow in optimizer code paths.