-
Notifications
You must be signed in to change notification settings - Fork 12
Update examples to use dataclasses to wrap process args #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/e2e_test |
GiGL Automation@ 17:10:43UTC : 🔄 @ 18:33:43UTC : ✅ Workflow completed successfully. |
|
/e2e_test |
GiGL Automation@ 22:22:59UTC : 🔄 @ 23:40:52UTC : ❌ Workflow failed. |
|
/e2e_test |
GiGL Automation@ 23:25:17UTC : 🔄 @ 24:38:29UTC : ✅ Workflow completed successfully. |
|
/e2e_test |
GiGL Automation@ 20:58:30UTC : 🔄 @ 22:16:04UTC : ✅ Workflow completed successfully. |
|
/e2e_test |
GiGL Automation@ 21:58:28UTC : 🔄 @ 23:14:30UTC : ✅ Workflow completed successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops :P
|
/unit_test_py |
GiGL Automation@ 22:26:45UTC : 🔄 @ 23:35:00UTC : ✅ Workflow completed successfully. |
Scope of work done
As discussed in #443, doing this makes it easier to safely expand on adding new process args.
Additionally, I've removed
inference_argsfrom the dataclass so we can have everything parsed at the higher level.Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO