fix: guard factory pool count overflow - #90
Merged
prodbycorne merged 5 commits intoJul 26, 2026
Merged
Conversation
✅ Deploy Preview for sdcontracts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jamilahmadzai
force-pushed
the
codex/smartdrop-poolcount-overflow-82
branch
from
July 17, 2026 07:46
304c3d1 to
0434d1d
Compare
Contributor
|
fix Ci build |
Contributor
Author
|
Fixed the CI breakage after the upstream merge and updated the branch to current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82
Bounty: GrantFox OSS campaign for issue #82
Summary
FactoryError::PoolCountOverflowwhen the factory cannot allocate the next pool IDPoolCountwithchecked_add(1)before deploying or writing a pool recordu32::MAXboundary so overflow leaves the count unchanged and does not create aPool(u32::MAX)recordValidation
cargo fmt --all -- --checkcargo test -p factory pool_count -- --nocapturecargo test -p factory create_pool -- --nocapturecargo test -p factory -- --nocapturecargo buildcargo test --workspace -- --nocapturegit diff --checkNotes
factory/src/lib.rsnow only usessaturating_addfor bounded pagination andchecked_addfor the pool-count incrementEvents::publishdeprecation warnings remain unchanged