C++-based Choreo generator program#1485
Open
shueja wants to merge 19 commits into
Open
Conversation
calcmogul
reviewed
May 17, 2026
calcmogul
reviewed
Jun 1, 2026
|
|
||
| template <typename T> | ||
| struct Dimension { | ||
| inline static const std::string tag = "default value"; |
Member
There was a problem hiding this comment.
You can probably use inline static constexpr std::string_view here since the string literals are constexpr and have global storage duration.
Collaborator
Author
|
This PR makes schema changes but I do not intend to offer an upgrade path because the field coordinate system is changing. Notable schema changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to avoid Rust-C++ FFI in the portion of Choreo that translates .chor and .traj into TrajoptLib calls. This depends on wpiutil and wpimath for maintainability and reuse of existing resources. The
choreo_core/include/datadirectory should be compilable with WITH_TRAJOPT not defined, in which case it will not depend on TrajoptLib and can be used on-robot.Not marking it as a draft, even though it isn't ready, because I want review comments on the code architecture.