docs: add name argument to SmartDashboard.putData in AutoChooser example#1479
Open
KuaaMU wants to merge 1 commit into
Open
docs: add name argument to SmartDashboard.putData in AutoChooser example#1479KuaaMU wants to merge 1 commit into
KuaaMU wants to merge 1 commit into
Conversation
The SmartDashboard.putData(Sendable) overload without a name argument results in the chooser being unusable from dashboards. Use the explicit putData(String, Sendable) overload to ensure the chooser is properly registered with a name. Fixes SleipnirGroup#1446
github-actions
Bot
added
the
component: documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing name argument to
SmartDashboard.putData()in the AutoChooser documentation example.Motivation
Fixes #1446. The
SmartDashboard.putData(autoChooser)call without a name argument results in the chooser being unusable from dashboards. The WPILibSmartDashboard.putData(Sendable)overload relies on the Sendable's default name, which may not be set properly forAutoChooser.Changes
docs/choreolib/auto-factory.md: ChangedSmartDashboard.putData(autoChooser)toSmartDashboard.putData("Auto Chooser", autoChooser)to use the explicit name overload.Verification
The fix follows the WPILib API convention where
SmartDashboard.putData(String, Sendable)is the recommended way to register sendables with a human-readable name on the dashboard.