Skip to content

fix(gateway): regression-test removed anonymous /thumbnails proxy - #73

Merged
SlavaKuntsov merged 1 commit into
mainfrom
fix/issue-45-private-thumbnails-auth
Sep 15, 2026
Merged

SlavaKuntsov merged 1 commit into
mainfrom
fix/issue-45-private-thumbnails-auth

Conversation

@SlavaKuntsov

Copy link
Copy Markdown
Owner

Closes #45

Summary

The vulnerability from #45 (private video thumbnails publicly served) was already fixed in #43: the anonymous /thumbnails/* MinIO proxy was removed from the gateway, the MinIO bucket is fully private, and metadata now returns presigned absolute thumbnail_url values (MINIO_PUBLIC_ENDPOINT).

This PR locks that in with a regression test:

  • services/gateway/cmd/server/main.go — router construction extracted from main() into a testable newRouter(cfg routerConfig) (mechanical refactor, no logic change).
  • services/gateway/cmd/server/main_test.go (new) — TestNoAnonymousThumbnailsProxy: GET /thumbnails/vid-1/thumb.jpg and GET /thumbnails/ must return 404 (no route — the anonymous proxy must never come back).

Acceptance criteria

Verification

Review

  • Independent review iteration 1: no blocking findings (details in the issue comment).

@SlavaKuntsov SlavaKuntsov self-assigned this Sep 15, 2026
@SlavaKuntsov
SlavaKuntsov merged commit 70ebf7b into main Sep 15, 2026
4 checks passed
@SlavaKuntsov
SlavaKuntsov deleted the fix/issue-45-private-thumbnails-auth branch September 17, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P0 gateway: protect private video thumbnails behind auth

1 participant