Skip to content

[CLOV-1606][BpkTooltip] Add zIndexValue prop#4517

Open
Ezreal Yang (Supremeyh) wants to merge 1 commit into
mainfrom
ez/clov-1606_BpkTooltip_zIndexValue
Open

[CLOV-1606][BpkTooltip] Add zIndexValue prop#4517
Ezreal Yang (Supremeyh) wants to merge 1 commit into
mainfrom
ez/clov-1606_BpkTooltip_zIndexValue

Conversation

@Supremeyh
Copy link
Copy Markdown
Contributor

@Supremeyh Ezreal Yang (Supremeyh) commented May 21, 2026

Mirror BpkPopover's zIndexValue API on BpkTooltip so consumers can override the floating container's z-index inline.

Default is undefined so the SCSS $bpk-zindex-tooltip token continues to drive the default z-index — keeping the existing behavior, and leaving consumer CSS overrides intact when the prop is not passed.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Mirror BpkPopover's `zIndexValue` API on BpkTooltip so consumers
can override the floating container's z-index inline.

Default is `undefined` so the SCSS `$bpk-zindex-tooltip` token
continues to drive the default z-index — keeping the existing
behavior, and leaving consumer CSS overrides intact when the prop
is not passed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 21, 2026 03:05
@Supremeyh Ezreal Yang (Supremeyh) added the patch Patch production bug label May 21, 2026
@skyscanner-backpack-bot
Copy link
Copy Markdown

Visit https://backpack.github.io/storybook-prs/4517 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link
Copy Markdown

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against a785737

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai: claude patch Patch production bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants