Skip to content

[NO-JIRA]fix BpkCheckboxV2 background color#4497

Merged
IrinaWei merged 2 commits into
mainfrom
fix-checkboxv2-background
May 19, 2026
Merged

[NO-JIRA]fix BpkCheckboxV2 background color#4497
IrinaWei merged 2 commits into
mainfrom
fix-checkboxv2-background

Conversation

@IrinaWei
Copy link
Copy Markdown
Contributor

@IrinaWei IrinaWei commented May 19, 2026

image

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copilot AI review requested due to automatic review settings May 19, 2026 09:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a hard-coded background-color: tokens.$bpk-canvas-day from the BpkCheckboxV2 box element so the checkbox no longer forces a light-mode canvas background (which would render incorrectly in dark mode / on non-canvas surfaces).

Changes:

  • Drop the background-color declaration from the .box style in BpkCheckboxV2.module.scss.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IrinaWei IrinaWei added the patch Patch production bug label May 19, 2026
@skyscanner-backpack-bot
Copy link
Copy Markdown

Visit https://backpack.github.io/storybook-prs/4497 to see this build running in a browser.

Copy link
Copy Markdown
Contributor

@RichardSyq Richard-Shen (RichardSyq) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IrinaWei IrinaWei merged commit c10d7a1 into main May 19, 2026
14 of 15 checks passed
@IrinaWei IrinaWei deleted the fix-checkboxv2-background branch May 19, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Patch production bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants