Support extension modifier on children declarations#1117
Open
Support extension modifier on children declarations#1117
Conversation
Add two new syntactic forms for declaring extension children: - Per-child: `| extension A` marks individual children as extension classes - Blanket: `extension children = | A | B` marks all children as extension Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extensionmodifier support onchildrendeclarations| extension Amarks individual children as extension classesextension children = | A | Bmarks all children as extension classesChanges
chi_extension: ?FileRangetoChildextensionfield toChildClassTree,modifiersfield toChildrenTreeextensionas a class member modifier, allows it onchildrenand individual child classeschi_extensionthrough to desugaredClass_defextensionon children and child classesTest plan
extension_children_per_child— validates| extension A()syntaxextension_children_blanket— validatesextension children =syntaxmodifier_childrenerror test — error message now says "Only 'extension' modifier is permitted"🤖 Generated with Claude Code