Add working example, clearer description, reorder arguments as in sig…#68
Open
Aerilius wants to merge 2 commits intoSketchUp:mainfrom
Open
Add working example, clearer description, reorder arguments as in sig…#68Aerilius wants to merge 2 commits intoSketchUp:mainfrom
Aerilius wants to merge 2 commits intoSketchUp:mainfrom
Conversation
…nature, rename arguments so that entities and corresponding transform have matching number
Contributor
|
@Aerilius, This snippet suggestion would need to be opened as a documentation Issue in the API tracker. (The stubs are generated from the C code comments and Thomas' script that used to accept PRs to change the core code has been broken for quite some time.) |
Contributor
|
Do we have a complimentary documentation issue open in the API tracker ? |
Contributor
|
@thomthom This PR Issue can be rejected and closed as it way behind and you're no longer accepting PRs for the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example of the method
Sketchup::Entities#intersect_withwas not helpful for understanding how this rather complex method works.transform1refers the transformation ofentities1although it refers to the receiver. One could also thinktransform2refers to the list of entitiesentities2although it refers to the target context for the intersection linesentities1.