test: make pathology mutations behavior-sensitive

[Sinity]

Summary

• Make the Claude vintage pathology red twin corrupt the membership verdict that the production invariant actually observes.
• Replace the duplicated 17-member fixture tuple with manifest-derived checks while independently requiring both append semantics.
• Exercise missing-member drift by deleting the scoped source row directly, keeping that oracle independent from verdict mutation.

Problem

The generic Claude vintage mutation deleted a raw row, which could fail for reasons outside the membership authority the invariant is intended to protect. Archive verification also copied every pathology member ID into a second hard-coded registry, creating a maintenance-only test that drifted whenever the production manifest grew.

Solution

tests/infra/pathology_zoo.py now changes the registered verdict from superseded_equivalent to superseded_prefix, so the red twin directly exercises the semantic membership decision. The missing-member mutation separately deletes the scoped raw row, proving deletion detection through a distinct path. tests/unit/maintenance/test_archive_verification.py now verifies the production manifest is non-empty, unique, fully linked to motivating Beads, and contains both self-describing and opaque append members without duplicating the complete registry.

This satisfies the implementation and test scope of polylogue-kmt1c. It does not claim a live cohort receipt or production archive mutation.

Verification

• devtools test --json tests/unit/infra/test_pathology_zoo.py tests/unit/infra/test_claude_vintage_live_proof.py tests/unit/maintenance/test_archive_verification.py::test_pathology_zoo_contract_is_production_owned_and_registered tests/unit/maintenance/test_archive_verification.py::test_pathology_zoo_invariants_red_twin tests/unit/maintenance/test_archive_verification.py::test_pathology_zoo_claude_vintage_registered_invariant_rejects_each_semantic_drift
  • 13 passed in 28.54s.
• devtools verify --quick --json
  • 25 checks passed in 128.62s at exact head 58378a76b3d86e033159d8b8ab597475c8c2bfd2.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b16c6cdc-9af1-4168-a1fa-49f7565fde0c

📥 Commits

Reviewing files that changed from the base of the PR and between 4f384e6 and 58378a7.

📒 Files selected for processing (2)

• tests/infra/pathology_zoo.py
• tests/unit/maintenance/test_archive_verification.py

---

📝 Walkthrough

Walkthrough

The Claude vintage pathology mutation now updates a membership decision instead of deleting a raw session. Archive verification tests now use structural manifest assertions and direct deletion for the missing-revision scenario.

Changes

Claude vintage pathology

Layer / File(s)	Summary
Update Claude vintage mutation tests/infra/pathology_zoo.py	The mutation selects the first matching superseded_equivalent membership by ascending source path and changes it to superseded_prefix.
Align archive verification scenarios tests/unit/maintenance/test_archive_verification.py	Manifest checks now validate structure, motivating beads, and required append members. The missing-revision case deletes the selected raw session directly before committing.

Estimated code review effort: 2 (Simple) | ~15 minutes

Mergeability Score: ⚪ Minimal · up to 58378

This test-only PR updates pathology mutation behavior and derives archive checks from the production manifest; focused tests and quick verification pass, so no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

• Sinity/polylogue#3757: Introduced the pathology-zoo fixture and archive-verification tests modified here.
• Sinity/polylogue#3949: Modified the same pathology setup and archive-verification test areas.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes the main change: making pathology mutations behavior-sensitive.
Description check	✅ Passed	The description covers the required change, problem, solution, verification, and bead disposition; omitted Changelog and Risks sections are appropriate for this test-only change.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/test/pathology-zoo-renewal

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Sinity]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a7366f1d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Sinity]

@codex review

Please review exact head 58378a7 after the two independent-oracle repairs. Focus on whether missing-member deletion and both append variants remain independently load-bearing.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 58378a76b3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".