Skip to content

fix(sources): classify sidecars before live session admission - #3784

Closed
Sinity wants to merge 1 commit into
masterfrom
feature/fix/artifact-sidecar-ingestion
Closed

fix(sources): classify sidecars before live session admission#3784
Sinity wants to merge 1 commit into
masterfrom
feature/fix/artifact-sidecar-ingestion

Conversation

@Sinity

@Sinity Sinity commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

Keep declared metadata and workflow sidecars as durable raw evidence instead of materializing them as sessions.

Problem

The validation-off worker shortcut and full/append live ingestion could override path-declared artifact classification, allowing session-shaped workflow records to become conversations.

Solution

Honor path classification before the fast stream shortcut and route declared non-session payloads through typed raw-artifact admission in full and append live paths.

Verification

  • Focused real-route suite: 101 passed
  • Adjacent taxonomy suite: 76 passed
  • devtools verify --quick: passed
  • git diff --check: passed

Ref polylogue-b508 and polylogue-ioz7

Problem: Agent metadata and workflow sidecars entered live ingestion through generic session paths. A session-shaped workflow journal could therefore materialize as a conversation, while full and append capture did not retain typed artifact evidence.

What changed: The validation-off worker shortcut now honors path-declared fact and raw-only artifacts. Full and append live ingestion route declared non-session payloads through the existing typed artifact admission API. Focused regressions cover worker non-materialization, full-ingest raw and blob retention, and append evidence retention.

Compatibility/migration: No schema, reindex, raw admission governance, revision governance, or blob lifecycle changes. Source bytes remain retained as raw artifacts.

Ref polylogue-b508

Ref polylogue-ioz7
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Sinity, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c0b539d3-f0f8-499d-b09b-9c6fb5d3fdcc

📥 Commits

Reviewing files that changed from the base of the PR and between 5f34505 and b81d36b.

📒 Files selected for processing (5)
  • polylogue/pipeline/services/ingest_worker.py
  • polylogue/sources/live/append_ingest.py
  • polylogue/sources/live/batch.py
  • tests/unit/pipeline/test_quarantine_fixtures.py
  • tests/unit/sources/test_live_batch_support.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Sinity

Sinity commented Aug 5, 2026

Copy link
Copy Markdown
Owner Author

Scope disposition: this PR is superseded by the merged sidecar admission work in Ref #3794 and the raw-admission routing in Ref #3772. The newer implementation covers the same full, append, and artifact paths with the shared ZIP admission contract. No additional code from this branch is required.

@Sinity

Sinity commented Aug 5, 2026

Copy link
Copy Markdown
Owner Author

Closed as superseded by the merged sidecar and raw-admission implementations documented above.

@Sinity Sinity closed this Aug 5, 2026
@Sinity
Sinity deleted the feature/fix/artifact-sidecar-ingestion branch August 10, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant