Skip to content

fix(storage): restore blocks.signature DDL dropped in the #3451 merge - #3459

Merged
Sinity merged 1 commit into
masterfrom
fix/restore-blocks-signature-ddl
Jul 31, 2026
Merged

fix(storage): restore blocks.signature DDL dropped in the #3451 merge#3459
Sinity merged 1 commit into
masterfrom
fix/restore-blocks-signature-ddl

Conversation

@Sinity

@Sinity Sinity commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Summary

Master cannot render. Restores an 11-line column definition that a conflict resolution dropped.

Problem

$ devtools render all --check
sqlite3.OperationalError: table blocks has no column named signature

That fails devtools verify --quick, which fails every branch's pre-push hook — so master being red here blocks all concurrent work, not just this file.

Cause

Resolving #3451's conflict against master, I took the PR branch's index.py wholesale and merged only its header comments. That branch predates #3447, so it never carried the blocks.signature column added by polylogue-vf9x — the provider attestation for empty-body THINKING blocks, which is the only surviving evidence besides block existence for Claude Code sessions since ~2026-06.

The result was the worst possible shape: the v50 header comment describing the column survived, so the file read as correct on inspection. The column itself was gone.

Solution

Restores the column definition and its comment, taken from the correctly-merged working copy. No other difference from master — git diff is +11 lines, one file.

Verification

devtools render all --check          clean (was OperationalError)
devtools lab policy schema-versioning "Schema evolution policy intact."
grep 'signature *TEXT' index.py      present in the blocks DDL

Note

Two process lessons worth recording. Mechanically union-merging a schema file is unsafe: the same resolution also collapsed two different IndexDeltaDeclaration(version=50, ...) blocks — vf9x and u6tl — into one, which would have silently dropped a declaration. That was caught before landing; this was not.

And devtools invoked from a linked worktree resolves polylogue through the venv's .pth to the main checkout, so a schema-version check can compare one tree's constant against another tree's declarations. PYTHONPATH does not override it.

Problem: master could not render. `devtools render all --check` failed with
sqlite3.OperationalError: table blocks has no column named signature, which
also fails `devtools verify --quick` and therefore every branch's pre-push
hook.

Cause: resolving #3451's conflict against master, I took the PR branch's
index.py wholesale and merged only its header comments. That branch predates
#3447, so it never had the blocks.signature column added by polylogue-vf9x --
the column that carries the provider attestation for empty-body THINKING
blocks. The v50 header comment describing the column survived; the column
itself did not.

What changed: restores the 11-line signature column definition and its
comment. No other difference from master.

Verification: devtools render all --check clean (was OperationalError);
devtools lab policy schema-versioning intact; blocks DDL contains
'signature TEXT' at the expected position.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Sinity, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3a8a85bd-0eca-4d0f-9c45-6d443ce96bc7

📥 Commits

Reviewing files that changed from the base of the PR and between 42bafb0 and 4cf84d8.

📒 Files selected for processing (1)
  • polylogue/storage/sqlite/archive_tiers/index.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Sinity
Sinity merged commit debcf66 into master Jul 31, 2026
2 of 3 checks passed
@Sinity
Sinity deleted the fix/restore-blocks-signature-ddl branch July 31, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant