-
Notifications
You must be signed in to change notification settings - Fork 1
fix(sources): stop discarding reasoning/thinking content on two origins #3447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,6 +111,7 @@ def message_from_record( | |
| "tool_result_is_error": b.tool_result_is_error, | ||
| "tool_result_exit_code": b.tool_result_exit_code, | ||
| "tool_result_outcome_unknown_reason": b.tool_result_outcome_unknown_reason, | ||
| "signature": b.signature, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This exposes Useful? React with 👍 / 👎. |
||
| } | ||
| ) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a Codex reasoning record carries identical text in both
summaryandcontent, the block logic correctly emits one block, butcombined_textstill joins both copies. The stored message therefore has doubled text and an inflatedword_count/message content hash, while block-based reads return only one copy. Apply the same distinctness check used forblockswhen constructing the message text.Useful? React with 👍 / 👎.