Skip to content

fix(sources): reconcile sidecar coverage with attachment evidence events #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sinity merged 1 commit into from
Jul 31, 2026
Merged

fix(sources): reconcile sidecar coverage with attachment evidence events #3437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions polylogue/sources/parsers/claude/code_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,6 +1469,7 @@ def _parse_code_records(
attachment_event = _attachment_sidecar_event(item, timestamp)
if attachment_event is not None:
session_events.append(attachment_event)
persisted_this_record = True
event_type = _SIDECAR_EVENT_TYPES.get(record_type)
if event_type is not None:
evidence_payload = _sidecar_evidence_payload(record_type, item)
Expand Down
14 changes: 7 additions & 7 deletions tests/unit/sources/test_claude_code_sidecar_evidence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ def test_attachment_hook_subtypes_share_one_event_type() -> None:
],
"sess-hook",
)
event_types = [e.event_type for e in parsed.session_events]
event_types = [e.event_type for e in parsed.session_events if e.event_type != "claude_parse_coverage"]
assert event_types == ["claude_hook_event", "claude_hook_event"]


Expand All @@ -342,7 +342,7 @@ def test_attachment_queued_command_reuses_queue_operation_event_type() -> None:
],
"sess-queue",
)
events = [(e.event_type, e.payload) for e in parsed.session_events]
events = [(e.event_type, e.payload) for e in parsed.session_events if e.event_type != "claude_parse_coverage"]
assert events == [
(
"claude_queue_operation",
Expand Down Expand Up @@ -372,7 +372,7 @@ def test_attachment_transient_subtype_emits_no_event() -> None:
],
"sess-transient",
)
assert parsed.session_events == []
assert [e for e in parsed.session_events if e.event_type != "claude_parse_coverage"] == []


def test_attachment_unrecognized_subtype_fails_loud() -> None:
Expand All @@ -389,7 +389,7 @@ def test_attachment_unrecognized_subtype_fails_loud() -> None:
],
"sess-unknown",
)
events = [(e.event_type, e.payload) for e in parsed.session_events]
events = [(e.event_type, e.payload) for e in parsed.session_events if e.event_type != "claude_parse_coverage"]
assert events == [
(
"claude_attachment_unclassified",
Expand All @@ -415,7 +415,7 @@ def test_attachment_deferred_tools_delta_drops_body_text_keeps_names() -> None:
],
"sess-delta",
)
events = [(e.event_type, e.payload) for e in parsed.session_events]
events = [(e.event_type, e.payload) for e in parsed.session_events if e.event_type != "claude_parse_coverage"]
assert events == [
(
"claude_capability_delta",
Expand Down Expand Up @@ -444,7 +444,7 @@ def test_attachment_skill_listing_extracts_names_not_full_text() -> None:
],
"sess-skills",
)
events = [(e.event_type, e.payload) for e in parsed.session_events]
events = [(e.event_type, e.payload) for e in parsed.session_events if e.event_type != "claude_parse_coverage"]
assert events == [
(
"claude_capability_snapshot",
Expand Down Expand Up @@ -481,7 +481,7 @@ def test_attachment_diagnostics_bounds_to_per_file_counts() -> None:
],
"sess-diag",
)
events = [(e.event_type, e.payload) for e in parsed.session_events]
events = [(e.event_type, e.payload) for e in parsed.session_events if e.event_type != "claude_parse_coverage"]
assert events == [
(
"claude_diagnostics",
Expand Down