fix(storage): classify duplicate-alias fan-out siblings as ineligible, not fatal

[Sinity]

Summary

Fix a live production bug (discovered minutes after deploying polylogue-ihc8's fix) where the daemon's raw-authority frontier census crashes entirely on the N:1 duplicate-alias fan-out follow-up case tracked by polylogue-dmvo.

Problem

_inspect_duplicate_raw_identity already returns status="ineligible" (never raises) when a fan-out sibling's own fold isn't currently possible — e.g. the single available canonical twin was already claimed by a different sibling's fold. _classify_frontier treated any status outside {eligible, already_repaired} as a fatal proof violation and raised, crashing the entire frontier census over one row's expected, benign non-eligibility.

Observed live: daemon writer released actor=maintenance.raw_materialization wait_s=0.000588 hold_s=543.959183 outcome=error queued=10 — a 9-minute writer-lock hold ending in an uncaught RuntimeError, repeating every retry cycle, starving 10 other queued daemon actors.

Solution

Add an explicit ineligible branch that classifies the row as UNRESOLVED_PROVENANCE/NONE (non-executable, reason preserved) instead of raising. Genuinely unexpected statuses still raise.

Verification

• devtools test tests/unit/storage/test_duplicate_raw_identity_repair.py → 10 passed (new regression test monkeypatches the proof helper to force the exact ineligible status; anti-vacuity confirmed by reverting the branch and observing the test fail with the exact live error message)
• devtools test tests/unit/storage/ -k "raw_reconciler or raw_authority or duplicate" → 85 passed
• mypy polylogue/storage/raw_reconciler.py → clean
• devtools verify --quick → exit 0

Ref polylogue-dmvo, polylogue-ihc8

Co-Authored-By: Claude noreply@anthropic.com

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of duplicate records that cannot be safely repaired.
  • Prevented one ineligible duplicate from interrupting classification of other records.
  • Clearly marks unresolved records as non-actionable while allowing eligible duplicates to remain available for repair.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9053242c-8afa-4014-8313-b4520badf905

📥 Commits

Reviewing files that changed from the base of the PR and between 3d68cc4 and a1e85d2.

📒 Files selected for processing (2)

• polylogue/storage/raw_reconciler.py
• tests/unit/storage/test_duplicate_raw_identity_repair.py

---

📝 Walkthrough

Walkthrough

The duplicate-alias frontier classifier now treats "ineligible" proof results as unresolved provenance instead of raising an error. A regression test confirms the census continues classifying eligible and ineligible siblings independently.

Changes

Duplicate-alias frontier census

Layer / File(s)	Summary
Classify ineligible proofs and validate sibling handling polylogue/storage/raw_reconciler.py, tests/unit/storage/test_duplicate_raw_identity_repair.py	Ineligible duplicate-alias proofs produce UNRESOLVED_PROVENANCE items with no actuator and the recorded reason, while the regression test verifies eligible siblings remain executable and the census does not raise.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• Sinity/polylogue#2962: Establishes the duplicate-alias frontier state machine modified by this PR.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main fix and matches the code changes.
Description check	✅ Passed	The description covers Summary, Problem, Solution, and Verification, with only non-critical template sections omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/duplicate-alias-ineligible-crash-dmvo

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}