fix(storage): declare index schema v40 query-unit-frame delta

[Sinity]

Summary

Adds the missing IndexDeltaDeclaration(version=40, ...) entry to polylogue/storage/sqlite/lifecycle.py's INDEX_DELTA_DECLARATIONS registry so devtools lab policy schema-versioning recognizes the index-tier v39→v40 schema bump.

Problem

devtools lab policy schema-versioning was failing on master: "undeclared index schema deltas found: 1, missing: [40]". PR #3068 ("bind query_units continuations to the archive epoch", polylogue-z9gh.9) bumped INDEX_SCHEMA_VERSION from 39 to 40 -- adding the query_unit_frame_state table plus its insert/update/delete triggers on session_links, sessions, messages, blocks, session_tags, session_profiles, and delegation_facts -- but never added the matching IndexDeltaDeclaration. INDEX_DELTA_DECLARATIONS jumped straight from version=39 to version=41 (the latter added by a later, unrelated PR for polylogue-2i2w), silently skipping 40.

Solution

Added IndexDeltaDeclaration(version=40, classes=(DerivedDeltaClass.INDEX_ONLY,), operations=(...)) describing the actual v40 delta: one FastForwardOperation (kind=REPLACE_TABLE) whose objects list the query_unit_frame_state table and all 21 query_unit_frame_* triggers, matching exactly what df86837 (#3068) added to INDEX_DDL. No canonical DDL, executor, or runtime behavior changes -- this is a declaration-only fix; the schema itself already exists and is deployed.

Verification

• devtools lab policy schema-versioning before: undeclared index schema deltas found: 1 / missing: [40]; after: undeclared index schema deltas found: 0 / Schema evolution policy intact.
• devtools test tests/unit/storage/test_index_fast_forward_lifecycle.py tests/unit/storage/test_index_fast_forward_executor.py: the two tests this fix targets (test_current_index_schema_has_a_complete_delta_declaration, test_schema_policy_rejects_an_index_bump_without_a_delta_declaration) now pass. Two unrelated pre-existing failures remain (test_nonsemantic_delta_without_operations_is_rejected, test_delta_without_a_declared_class_is_rejected) -- confirmed via git stash to already fail identically on master, caused by a separate latent bug where invalid_versions flags every declaration with version > current_version regardless of the v40 gap. Out of scope here.
• mypy --strict polylogue/storage/sqlite/lifecycle.py: no issues
• ruff check / ruff format --check on the touched file: clean
• devtools render all --check: no drift
• devtools verify --quick (pre-push hook): passed

Ref polylogue-5h5y

Co-Authored-By: Claude noreply@anthropic.com

Summary by CodeRabbit

• Improvements
  • Added a storage upgrade that introduces query-unit frame state tracking.
  • Improved synchronization of session, message, block, tag, profile, and delegation changes through automatic database updates.
  • Existing data is upgraded automatically when the application applies the new storage version.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7ffa1db5-f1db-49f4-aeda-652ac25216f8

📥 Commits

Reviewing files that changed from the base of the PR and between b397f7e and a6aab6d.

📒 Files selected for processing (1)

• polylogue/storage/sqlite/lifecycle.py

---

📝 Walkthrough

Walkthrough

The SQLite lifecycle registry adds index schema version 40 with an index-only clone-forward operation that creates query_unit_frame_state and associated insert, update, and delete triggers.

Changes

SQLite index schema update

Layer / File(s)	Summary
Declare version 40 index objects polylogue/storage/sqlite/lifecycle.py	Adds an INDEX_ONLY declaration using REPLACE_TABLE for query_unit_frame_state and triggers on session, message, block, tag, profile, and delegation tables.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• Sinity/polylogue#2788: Adds related planning and policy logic for the SQLite index fast-forward declaration registry.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately describes the missing v40 index schema delta declaration.
Description check	✅ Passed	The description covers summary, problem, solution, and verification; missing sections are reasonably skippable for this internal declaration-only fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/fix/index-schema-v40-delta-declaration

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}