fix(rebuild): target stale thread materializations - #3278
Conversation
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe rebuild flow now emits stage timings, refreshes targeted planner statistics periodically, preserves null session sort keys, accounts for aggregate insight debt, and restores persisted byte-governed heads during membership replay. Tests cover timing outputs, planner refresh policy, null keys, repair targeting, and replay authority. ChangesRebuild diagnostics and planner statistics
Session-insight materialization and repair
Persisted membership-head authority
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a001af05a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| measured = conn.execute("SELECT count(*) FROM sqlite_stat1").fetchone()[0] | ||
| assert measured > 0 | ||
| measured_tables = {str(row[0]) for row in conn.execute("SELECT DISTINCT tbl FROM sqlite_stat1").fetchall()} | ||
| assert {"sessions", "messages", "blocks", "session_links", "action_pairs"} <= measured_tables |
There was a problem hiding this comment.
This test deletes all seeded statistics but inserts no table rows, and SQLite does not create sqlite_stat1 entries when ANALYZE runs against empty tables. Consequently, the focused node tests/unit/storage/test_planner_statistics_seed.py::test_refresh_generation_planner_statistics_measures_real_tables deterministically fails with measured_tables == set() instead of validating the new table-selection policy; seed representative rows before refreshing statistics or change the assertion to account for empty tables.
AGENTS.md reference: AGENTS.md:L351-L357
Useful? React with 👍 / 👎.
Problem: rebuild_index.py's bulk-build derived-state repopulate still called rebuild_fts_index_sync with a resume_from_empty_message_index kwarg that master already dropped from the function signature via a separately-merged FTS convergence pass — this branch had gone stale enough that its own remaining net diff (once rebased past everything master already absorbed in parallel) reduced to this one call. What changed: call rebuild_fts_index_sync with no extra kwarg, matching its current signature. Verification: devtools test tests/unit/maintenance/test_rebuild_index_bulk_build.py tests/unit/storage/test_planner_statistics_seed.py; devtools verify --quick. Co-Authored-By: Codex <noreply@openai.com>
1a001af to
872bf34
Compare
|
Rebased onto current master: 3 of the 4 commits ( Verification: |
1 participant
Summary
Repair thread-only insight debt without an archive-wide aggregate refresh, and expose precise timings for terminal index-rebuild stages.
Problem
A full replay left four sessions with stale thread materialization markers because null source sort keys were replaced by a thread high-water mark. The repair planner excluded thread markers from targeted candidates and could classify thread-only debt as already ready. Terminal bulk derived rebuilds had no stage-level visibility.
Solution
Preserve null sort keys, include thread markers in candidate selection, rebuild only affected roots, and log FTS/trigram/action-pair/delegation/parity/readiness/promotion durations.
Verification
"timestamp": "2026-07-26T10:36:07.775809+00:00",
"git_head": "1a001af05afa3b1045fe199fc99d58f68124d687",
"tier": "quick",
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3",
"steps": [
{
"name": "ruff format",
"duration_s": 0.01,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/01-ruff-format"
},
{
"name": "ruff check",
"duration_s": 0.01,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/02-ruff-check"
},
{
"name": "mypy",
"duration_s": 0.55,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/03-mypy"
},
{
"name": "render all",
"duration_s": 8.59,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/04-render-all"
},
{
"name": "verify topology",
"duration_s": 0.46,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/05-verify-topology"
},
{
"name": "verify layering",
"duration_s": 3.9,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/06-verify-layering"
},
{
"name": "verify closure-matrix",
"duration_s": 0.3,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/07-verify-closure-matrix"
},
{
"name": "lab schema roundtrip",
"duration_s": 0.91,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/08-lab-schema-roundtrip"
},
{
"name": "verify manifests",
"duration_s": 1.78,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/09-verify-manifests"
},
{
"name": "verify ci-workflows",
"duration_s": 0.35,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/10-verify-ci-workflows"
},
{
"name": "verify doc-commands",
"duration_s": 2.62,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/11-verify-doc-commands"
},
{
"name": "verify docs-coverage",
"duration_s": 2.5,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/12-verify-docs-coverage"
},
{
"name": "verify test-infra-currency",
"duration_s": 0.39,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/13-verify-test-infra-currency"
},
{
"name": "verify test-clock-hygiene",
"duration_s": 2.24,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/14-verify-test-clock-hygiene"
},
{
"name": "verify pytest-timeout-overrides",
"duration_s": 3.96,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/15-verify-pytest-timeout-overrides"
},
{
"name": "verify degrade-loudly",
"duration_s": 1.23,
"exit": 0,
"run_id": "20260726T103537Z-quick-358301-4b0619a3",
"artifact_dir": ".cache/verify/runs/20260726T103537Z-quick-358301-4b0619a3/steps/16-verify-degrade-loudly"
}
],
"total_duration_s": 30.09,
"exit_code": 0
} — passed
No tracker file is included.
Summary by CodeRabbit
Bug Fixes
Performance & Diagnostics
Reliability