-
Notifications
You must be signed in to change notification settings - Fork 1
perf(sources): rebuild fast path — stage telemetry, spill cache, commit batching #3208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
35bba99
perf(sources): no-fsync census spill on the data disk + decoded-sessi…
Sinity 70c1ecc
perf(maintenance): opt the rebuild path into census/replay commit bat…
Sinity c41040f
feat(sources): per-page stage-timing telemetry for historical backfill
Sinity 7beac12
fix(sources): telemetry review fixes — polylogue logger, census recei…
Sinity 0a093c8
fix(sources): keep replay phase at per-cohort commits under census ba…
Sinity 4aa817d
fix(sources): FIFO eviction for the decoded-session spill layer
Sinity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a rebuild page contains an incomplete membership cohort, this opt-in passes
manage_transaction=False, butapply_raw_membership_classificationstill enterswith connfor that cohort’s non-terminal correction (polylogue/storage/sqlite/archive_tiers/archive.py:3430-3437). That context commits the entire shared source connection, including decisions and blob refs from earlier cohorts in the current 200-unit batch, while their index transaction remains uncommitted untilcommit_replay_unit()reaches the boundary. A crash after this inner commit therefore leaves durablesource.dbstate ahead of the rolled-back inactive index, violating the whole-batch crash guarantee; isolate/remove that inner commit before enabling batching for rebuilds.Useful? React with 👍 / 👎.