Skip to content

refactor(storage): consolidate _table_exists, fix drift found while verifying #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sinity merged 1 commit into from
Jul 15, 2026
Merged

refactor(storage): consolidate _table_exists, fix drift found while verifying #2912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .beads/interactions.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,3 +762,33 @@
{"id":"int-1c480eab","kind":"field_change","created_at":"2026-07-15T00:09:17.141375983Z","actor":"Sinity","issue_id":"polylogue-a7xr.3","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Satisfied by PR #2881: message_prose_sql() builder in storage/embeddings/materialization.py, correlated subquery with ORDER BY b.position for deterministic ordering, all 5 sites (materialization.py, message_type_backfill.py, demo/seed.py, demo/constructs.py) migrated. Independently verified: devtools test tests/unit/pipeline/test_message_type_backfill.py, 6 passed."}}
{"id":"int-20ae6c4c","kind":"field_change","created_at":"2026-07-15T00:13:47.868211443Z","actor":"Sinity","issue_id":"polylogue-pf1","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Satisfied by PR #2897: docs/plans/STORAGE_TWINS_DIVERGENCES.md classifies all 10 sync/async divergences with file:line + rationale, tests/unit/storage/test_storage_twins.py regenerates the diff and fails on new/undocumented divergence. Independently verified: devtools test tests/unit/storage/test_storage_twins.py, 9 passed."}}
{"id":"int-b0c288d6","kind":"field_change","created_at":"2026-07-15T01:15:45.30246704Z","actor":"Sinity","issue_id":"polylogue-02aw","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Premise didn't hold up on investigation (2026-07-14 reconciliation pass): the 'protected test files' list this bead wanted to move from CLAUDE.md prose into a validated manifest has no documented reason for any of its 6 entries anywhere in project history. Traced it to its origin (PR #134, an unrelated DB-performance PR that bolted the list on as incidental doc scaffolding with zero justification) and confirmed it was never revisited or expanded across ~2500 subsequent PRs. Building manifest+gate enforcement for an unreasoned, unmaintained list would launder its arbitrariness behind a false patina of rigor rather than fix a real problem -- a category-level post-hoc justification (property tests/integration/security/foundational-CRUD look prunable) was tried and rejected as unfalsifiable: the same reasoning shape would defend any random file subset equally well. Removed the CLAUDE.md prose line outright instead of encoding it. If specific test coverage genuinely needs protecting, that should be established by evidence (unique-assertion/coverage analysis) at the time, not inherited from an unexplained list."}}
{"id":"int-fce8320c","kind":"field_change","created_at":"2026-07-15T01:46:36.571431321Z","actor":"Sinity","issue_id":"polylogue-fs1.7","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Satisfied by PR #2876: sources/hooks.py extended to accept provider='hermes' through the durable atomic-enqueue/idempotent-drain contract, plus a payload hygiene guard (_reject_duplicated_transcript). sources/parsers/hermes_lifecycle.py owns the event-type taxonomy (on_session_end vs on_session_finalize) and reconcile_lifecycle_events(), which renders an incomplete event stream visible rather than silently accepting a gap. schemas/hermes_export_contract.py defines a versioned per-session export schema (HermesArchivalExportV1) with a checked-in fixture. Independent adversarial review (2026-07-14) found and the PR fixed a real order-dependency bug in reconcile_lifecycle_events' pairing algorithm (order-independent membership-based pairing now, 4 new adversarial tests)."}}
{"id":"int-7fa2bab3","kind":"field_change","created_at":"2026-07-15T02:09:38.005602085Z","actor":"Sinity","issue_id":"polylogue-itvd","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Satisfied by PR #2898 (merged 5d99611f4): fixed the confirmed crash-risk write path (rebuild.py's _PER_SESSION_INSIGHT_TABLES orphan-pruning loop), two silent-degradation bugs (coordination/envelope.py's table-presence gate blocking all agent-coordination evidence queries; status.py/readiness.py's table_name pointing at dropped tables), a real correctness bug affecting every subagent run system-wide (projected_run_from_row() hardcoded role='main'), a query-selectivity bug (observed_event_source_pushdown's kind field wasn't marked selective, so kind:tool_finished alone silently returned zero rows), removed the fully dead 357-line materialized write path, and rewrote 13 test files whose fixtures assumed the old materialized-table model. devtools test across all touched files: 773 passed; all 10 failures + 22 errors independently confirmed pre-existing via baseline comparison against clean origin/master with the branch diff stashed away. mypy --strict clean (991 files)."}}
{"id":"int-52d93b56","kind":"field_change","created_at":"2026-07-15T02:10:07.878923704Z","actor":"Sinity","issue_id":"polylogue-dab","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Satisfied by PR #2898 (merged 5d99611f4, closing the polylogue-itvd fallout-completion tracker for this same bead). session_runs/session_observed_events/session_context_snapshots DDL dropped (schema v37); all reads are source-derived CTEs over sessions/blocks (run_relation_sql/observed_event_relation_sql/context_snapshot_relation_sql in run_projection_relations.py). Fails loudly on stale/partial state: include_materialized=True now raises ValueError naming polylogue-dab explicitly rather than silently falling back. Regression guard: 13 test files rewritten to seed real sessions/blocks and assert against the source-derived model; devtools test 773 passed, all remaining failures independently confirmed pre-existing against clean origin/master. Verification artifact: mypy --strict clean (991 files), devtools render all --check clean (topology projection regenerated for the dropped tables)."}}
{"id":"int-36333a1d","kind":"field_change","created_at":"2026-07-15T16:38:50.978652382Z","actor":"Sinity","issue_id":"polylogue-ovme","extra":{"field":"priority","new_value":"1","old_value":"2"}}
{"id":"int-76fb1751","kind":"field_change","created_at":"2026-07-15T16:38:52.652483687Z","actor":"Sinity","issue_id":"polylogue-9itr","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Superseded by ovme ArchiveLocation. Its split-tier config-path reproduction and canary are preserved verbatim as acceptance criteria beside the phantom benchmark write regression; both arise from ambiguous archive-root/tier/generation Path handling."}}
{"id":"int-eb659c86","kind":"field_change","created_at":"2026-07-15T16:38:53.631601069Z","actor":"Sinity","issue_id":"polylogue-s7ae.8","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Superseded by 20d.17 generalized StatusComponentSpec/StatusSnapshot. All coordination-specific latency baselines, stage timing, source-fingerprint invalidation, compact/detail semantics, p95 target, and live dogfood remain explicit acceptance criteria; PR #2809/#2816 stay landed evidence."}}
{"id":"int-e88c8c6f","kind":"field_change","created_at":"2026-07-15T16:39:50.505262127Z","actor":"Sinity","issue_id":"polylogue-cuxz","extra":{"field":"priority","new_value":"1","old_value":"2"}}
{"id":"int-e2d99094","kind":"field_change","created_at":"2026-07-15T16:39:51.023002759Z","actor":"Sinity","issue_id":"polylogue-v5eh","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Superseded by cuxz EvidenceValue AC #6: evidence versus inference must render by default from the shared authority axes. This is no longer an isolated registry flag decision."}}
{"id":"int-806de433","kind":"field_change","created_at":"2026-07-15T16:39:51.508804884Z","actor":"Sinity","issue_id":"polylogue-9l5.7.1","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Superseded by cuxz EvidenceValue AC #1/#5/#7: work-event and profile inference producers declare structural, derived, or heuristic authority through the shared protocol; 9l5.7 remains the metric/statistics consumer."}}
{"id":"int-5701590a","kind":"field_change","created_at":"2026-07-15T16:39:51.996382088Z","actor":"Sinity","issue_id":"polylogue-q30k","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Superseded by cuxz EvidenceValue AC #2/#4: no absence sentinel may fabricate time, and the exact transforms.py 1970 regression is retained as a required production-route fixture."}}
{"id":"int-d6b0213a","kind":"field_change","created_at":"2026-07-15T16:39:52.485873597Z","actor":"Sinity","issue_id":"polylogue-4r2r","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Superseded by cuxz EvidenceValue AC #5: naked or always-zero confidence must be removed or become definition/evidence/calibration-bound. The session phase field is the seeded anti-vacuity case."}}
{"id":"int-0d864b13","kind":"field_change","created_at":"2026-07-15T16:44:09.312951248Z","actor":"Sinity","issue_id":"polylogue-4ts","extra":{"field":"priority","new_value":"1","old_value":"4"}}
{"id":"int-2c9ecba8","kind":"field_change","created_at":"2026-07-15T16:44:11.611219577Z","actor":"Sinity","issue_id":"polylogue-o21","extra":{"field":"priority","new_value":"1","old_value":"2"}}
{"id":"int-5664bbdb","kind":"field_change","created_at":"2026-07-15T16:44:12.129330571Z","actor":"Sinity","issue_id":"polylogue-j9dt","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Superseded by o21 declaration/consumer completeness. The exact removed continue --format json workflow examples are retained as an executable seeded regression; product resolution must derive from the live CLI declaration rather than a separate stale workflow vocabulary."}}
{"id":"int-8aa1b76b","kind":"field_change","created_at":"2026-07-15T16:48:55.256804805Z","actor":"Sinity","issue_id":"polylogue-avmq","extra":{"field":"priority","new_value":"2","old_value":"4"}}
{"id":"int-998cbd4c","kind":"field_change","created_at":"2026-07-15T16:51:13.313691202Z","actor":"Sinity","issue_id":"polylogue-vt0m","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Superseded by polylogue-o21. The three missing MCP smoke invocations are a seeded regression for declare-once tool metadata: valid/invalid production invocation examples and discovery coverage are now generated from the tool declaration rather than repaired in a parallel _KNOWN_MINIMAL list."}}
{"id":"int-c89a2d78","kind":"field_change","created_at":"2026-07-15T16:54:45.120155734Z","actor":"Sinity","issue_id":"polylogue-ldau","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Superseded by polylogue-uh6c with canonical judgment supplied by polylogue-37t.12. Agent-authored TAG is the asserted-membership authority case of the three-axis tag model; its bypass, existing-row short-circuit, visibility, and accept transition are now explicit owner acceptance criteria."}}
{"id":"int-0902002a","kind":"field_change","created_at":"2026-07-15T16:54:46.623299472Z","actor":"Sinity","issue_id":"polylogue-j5xg","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Split into existing invariant owners instead of preserving one two-topic decision bead. polylogue-cijx now owns the session_commits production relation/removal decision; polylogue-xul7 owns blocks_command_trigram measurement, activation, or deletion. Both owner ACs explicitly forbid the current silent placeholders."}}
{"id":"int-ab651861","kind":"field_change","created_at":"2026-07-15T17:04:38.316745422Z","actor":"Sinity","issue_id":"polylogue-mjo1","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Fully subsumed by polylogue-9e5.8.7, which owns the same Provider-import layering gate with stronger semantic-boundary design, false-positive exclusions, seeded regression proof, and standard verify integration."}}
{"id":"int-f48ab6a6","kind":"field_change","created_at":"2026-07-15T17:04:44.997997128Z","actor":"Sinity","issue_id":"polylogue-37t.5","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Absorbed into polylogue-mhx.1: the provider abstraction now owns the local LiteLLM implementation, seeded/live-corpus evaluation, local/cloud parity, retrieval provenance, disabled/error behavior, and secret-redaction proof as one completion contract."}}
{"id":"int-8d72d40d","kind":"field_change","created_at":"2026-07-15T17:48:29.698746627Z","actor":"Sinity","issue_id":"polylogue-z9gh.3","extra":{"field":"priority","new_value":"0","old_value":"1"}}
{"id":"int-d8189f29","kind":"field_change","created_at":"2026-07-15T17:57:26.61275355Z","actor":"Sinity","issue_id":"polylogue-8jg9.1","extra":{"field":"assignee","new_value":"","old_value":"Sinity"}}
{"id":"int-62e5c9a7","kind":"field_change","created_at":"2026-07-15T17:58:32.93335193Z","actor":"Sinity","issue_id":"polylogue-ap7","extra":{"field":"assignee","new_value":"","old_value":"Sinity"}}
{"id":"int-c087eacd","kind":"field_change","created_at":"2026-07-15T17:58:32.953155096Z","actor":"Sinity","issue_id":"polylogue-rxdo.4","extra":{"field":"assignee","new_value":"","old_value":"Sinity"}}
{"id":"int-fcb60ca4","kind":"field_change","created_at":"2026-07-15T17:58:32.974048781Z","actor":"Sinity","issue_id":"polylogue-83u.2","extra":{"field":"assignee","new_value":"","old_value":"Sinity"}}
{"id":"int-85910196","kind":"field_change","created_at":"2026-07-15T17:58:32.99222375Z","actor":"Sinity","issue_id":"polylogue-4ts.3","extra":{"field":"assignee","new_value":"","old_value":"Sinity"}}
{"id":"int-83cafc11","kind":"field_change","created_at":"2026-07-15T18:01:29.588289671Z","actor":"Sinity","issue_id":"polylogue-yeq","extra":{"field":"priority","new_value":"1","old_value":"3"}}
{"id":"int-f49f0446","kind":"field_change","created_at":"2026-07-15T18:04:49.344104753Z","actor":"Sinity","issue_id":"polylogue-ng9m","extra":{"field":"status","new_value":"open","old_value":"in_progress"}}
{"id":"int-ffb18f2f","kind":"field_change","created_at":"2026-07-15T18:04:49.344168028Z","actor":"Sinity","issue_id":"polylogue-ng9m","extra":{"field":"assignee","new_value":"","old_value":"Sinity"}}
{"id":"int-7da2fbdf","kind":"field_change","created_at":"2026-07-15T18:12:41.670406785Z","actor":"Sinity","issue_id":"polylogue-oucx","extra":{"field":"priority","new_value":"2","old_value":"3"}}
Loading