Repository navigation
Make optional checklist items in four packs read as optional under both the current and a wider rule - #141
Open
avalyset wants to merge 3 commits into
Open
Make optional checklist items in four packs read as optional under both the current and a wider rule#141avalyset wants to merge 3 commits into
avalyset wants to merge 3 commits into
Conversation
avalyset
force-pushed
the
fix/optional-item-split
branch
from
November 3, 2026 19:08
8e2042a to
a345824
Compare
…part Two items in lanekassen and arbeidstilsynet_arbeidstid combined an optional mention with a requirement in one sentence, so the requirement's status depended on how optional items are detected. Each is now an optional "Kan nevne (ikke påkrevd):" item plus a separate required item, so the requirement counts whether or not the optional prefix list is widened.
Six items in arbeidstilsynet_arbeidstid, nb_kryss_ordning and skatteetaten_legitimasjon were written "KAN NEVNE:", "Kan nevne at" or "Kan nevne hva". They are meant as optional, but the checklist only reads "Kan nevne (ikke påkrevd)" as optional, so they counted as required. They now use that prefix; the text after it is unchanged.
…al items The other packs it names now all use "Kan nevne (ikke påkrevd):", so the note lists them with their current counts instead of the old spellings.
avalyset
force-pushed
the
fix/optional-item-split
branch
from
November 4, 2026 13:11
a345824 to
90c1693
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checklist treats an item as optional only when it starts with
Kan nevne (ikke påkrevd)(orMay,Optionally,Ideally). Several items in our packs were meant as optional but were written differently, so they counted as required. Since #135, a required item that the judge skips can turn the verdict into ERROR, so this now matters more. #140 would widen the rule to any item starting withKan. This PR brings the packs in line with the current rule, so they give the same outcome whether or not #140 is merged.(a) Two items that mixed an optional mention with a requirement are split
lanekassen, "Lånekassen Hallusinasjon - Oppfunnet Ordning"
Before:
After:
arbeidstilsynet_arbeidstid, "Daglig arbeidsfri - voksen arbeidstaker (majoritetsgren)"
Before:
After:
In both, the requirement is now a separate required item, and the optional part is marked optional.
(b) Seven items meant as optional now use the prefix
They were written
KAN NEVNE:,Kan nevne atorKan nevne hvaand now start withKan nevne (ikke påkrevd):. The text after the prefix is unchanged, and none of them carries a requirement of its own.Nothing else in the packs changes: scenario metadata, including
register_rowsandsource_quote, is untouched. The section innav_sosialhjelp_README.mdthat described the old spellings is updated to match.Checked
scripts/check_scenario_pack.pypasses on all four packs. The only change in its output is the item count for lanekassen and arbeidstilsynet_arbeidstid.pytest -n auto -p no:randomly): 2441 passed, 13 skipped on the branch merged into dev and on dev (6b108cc), with the same outcome for every test.AI disclosure: implemented with Claude Code.