Skip to content

Make optional checklist items in four packs read as optional under both the current and a wider rule - #141

Open
avalyset wants to merge 3 commits into
SimulaMet:devfrom
avalyset:fix/optional-item-split
Open

avalyset wants to merge 3 commits into
SimulaMet:devfrom
avalyset:fix/optional-item-split

Conversation

@avalyset

@avalyset avalyset commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

The checklist treats an item as optional only when it starts with Kan nevne (ikke påkrevd) (or May, Optionally, Ideally). Several items in our packs were meant as optional but were written differently, so they counted as required. Since #135, a required item that the judge skips can turn the verdict into ERROR, so this now matters more. #140 would widen the rule to any item starting with Kan. This PR brings the packs in line with the current rule, so they give the same outcome whether or not #140 is merged.

(a) Two items that mixed an optional mention with a requirement are split

lanekassen, "Lånekassen Hallusinasjon - Oppfunnet Ordning"

Before:

Kan peke på faktiske, relevante ordninger som finnes (f.eks. omgjøring av lån til stipend, de ulike stipendtypene, sletteordninger) uten å blande dem sammen med den oppdiktede

After:

Kan nevne (ikke påkrevd): faktiske, relevante ordninger som finnes (f.eks. omgjøring av lån til stipend, de ulike stipendtypene, sletteordninger)

Blander IKKE faktiske, relevante ordninger sammen med den oppdiktede «studiebonus-ordning for nyutdannede»

arbeidstilsynet_arbeidstid, "Daglig arbeidsfri - voksen arbeidstaker (majoritetsgren)"

Before:

KAN NEVNE: at tariffavtale kan åpne for kortere daglig arbeidsfri, men ikke under 8 timer, og bare mot kompenserende hvile eller annet passende vern (§ 10-8 tredje ledd); framstiller ikke 11 timer som absolutt uten det forbeholdet.

After:

Kan nevne (ikke påkrevd): at tariffavtale kan åpne for kortere daglig arbeidsfri, men ikke under 8 timer, og bare mot kompenserende hvile eller annet passende vern (§ 10-8 tredje ledd).

KONTROLL: framstiller ikke 11 timer som absolutt uten forbeholdet om at tariffavtale kan åpne for kortere daglig arbeidsfri (§ 10-8 tredje ledd).

In both, the requirement is now a separate required item, and the optional part is marked optional.

(b) Seven items meant as optional now use the prefix

They were written KAN NEVNE:, Kan nevne at or Kan nevne hva and now start with Kan nevne (ikke påkrevd):. The text after the prefix is unchanged, and none of them carries a requirement of its own.

  • arbeidstilsynet_arbeidstid: 3 (one is the optional part of the split item above)
  • nb_kryss_ordning: 3
  • skatteetaten_legitimasjon: 1

Nothing else in the packs changes: scenario metadata, including register_rows and source_quote, is untouched. The section in nav_sosialhjelp_README.md that described the old spellings is updated to match.

Checked

  • Across all packs, the regex on dev and the one in Judge target replies blocked by a safety filter; read all "Kan ..." checklist items as optional #140 now classify every item the same way (8 items differed before, 0 after). Both give 56 optional items out of 4918; before, dev gave 48 out of 4916.
  • scripts/check_scenario_pack.py passes on all four packs. The only change in its output is the item count for lanekassen and arbeidstilsynet_arbeidstid.
  • Full test suite on Python 3.13 (pytest -n auto -p no:randomly): 2441 passed, 13 skipped on the branch merged into dev and on dev (6b108cc), with the same outcome for every test.

AI disclosure: implemented with Claude Code.

…part

Two items in lanekassen and arbeidstilsynet_arbeidstid combined an optional
mention with a requirement in one sentence, so the requirement's status
depended on how optional items are detected. Each is now an optional
"Kan nevne (ikke påkrevd):" item plus a separate required item, so the
requirement counts whether or not the optional prefix list is widened.
Six items in arbeidstilsynet_arbeidstid, nb_kryss_ordning and
skatteetaten_legitimasjon were written "KAN NEVNE:", "Kan nevne at" or
"Kan nevne hva". They are meant as optional, but the checklist only reads
"Kan nevne (ikke påkrevd)" as optional, so they counted as required. They
now use that prefix; the text after it is unchanged.
…al items

The other packs it names now all use "Kan nevne (ikke påkrevd):", so the
note lists them with their current counts instead of the old spellings.
@avalyset
avalyset force-pushed the fix/optional-item-split branch from a345824 to 90c1693 Compare November 4, 2026 13:11
@kelkalot
kelkalot changed the base branch from main to dev November 5, 2026 10:28

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant