Skip to content

MS-1493 Fame provider cleanup - #1773

Merged
luhmirin-s merged 2 commits into
feature/MS-1498-frame-provider-loginfrom
feature/MS-1493-frame-provider-cleanup
Aug 11, 2026
Merged

MS-1493 Fame provider cleanup#1773
luhmirin-s merged 2 commits into
feature/MS-1498-frame-provider-loginfrom
feature/MS-1493-frame-provider-cleanup

Conversation

@luhmirin-s

Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 2026.3.0

Notable changes

  • Deleted now unused camera-related classes
  • Moved custom views that are related to camera to the infra module

Testing guidance

  • All should compile and works as usual.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@luhmirin-s
luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team August 6, 2026 13:59
@cla-bot cla-bot Bot added the ... label Aug 6, 2026
@luhmirin-s luhmirin-s changed the title Feature/ms 1493 frame provider cleanup MS-1493 Fame provider cleanup Aug 6, 2026
@luhmirin-s

Copy link
Copy Markdown
Contributor Author

The "uncovered" code is an anonymous object within a custom view class.

@luhmirin-s
luhmirin-s force-pushed the feature/MS-1493-frame-provider-cleanup branch from 74d9d05 to 91396cf Compare August 6, 2026 14:17
@luhmirin-s

Copy link
Copy Markdown
Contributor Author

The missing code coverage is Sonar bug with the anonymous internal classes. I don't see benefit in adding workaround just to appease the scanner.

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@luhmirin-s
luhmirin-s force-pushed the feature/MS-1493-frame-provider-cleanup branch from 91396cf to d6df69a Compare August 10, 2026 12:44
@luhmirin-s
luhmirin-s force-pushed the feature/MS-1493-frame-provider-cleanup branch from d6df69a to ab2f453 Compare August 11, 2026 07:20
@luhmirin-s
luhmirin-s force-pushed the feature/MS-1493-frame-provider-cleanup branch from ab2f453 to 5a32afa Compare August 11, 2026 08:50
@luhmirin-s
luhmirin-s merged commit b31a1b3 into main Aug 11, 2026
11 of 12 checks passed
@luhmirin-s
luhmirin-s deleted the feature/MS-1493-frame-provider-cleanup branch August 11, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants