Skip to content

MS-1498 Frame provider in login - #1771

Merged
luhmirin-s merged 1 commit into
feature/MS-1495-frame-provider-face-capturefrom
feature/MS-1498-frame-provider-login
Aug 11, 2026
Merged

MS-1498 Frame provider in login#1771
luhmirin-s merged 1 commit into
feature/MS-1495-frame-provider-face-capturefrom
feature/MS-1498-frame-provider-login

Conversation

@luhmirin-s

Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 2026.3.0

Notable changes

  • Migrating MFID OCR fragment to use the new camera frame provider.
  • QR detection is delegated to the new post-processing use case.

Testing guidance

  • Testiny MFID login test cases. There should be no changes in UX.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@luhmirin-s
luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and a lite review from Copilot and removed request for a team August 6, 2026 12:53
@cla-bot cla-bot Bot added the ... label Aug 6, 2026
@luhmirin-s
luhmirin-s changed the base branch from main to feature/MS-1495-frame-provider-face-capture August 6, 2026 12:53
@luhmirin-s luhmirin-s changed the title Feature/ms 1498 frame provider login MS-1498 Frame provider in login Aug 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Login feature’s QR scanner to use the new :infra:camera frame provider pipeline, moving QR detection into a post-processing use case to align with the newer camera architecture.

Changes:

  • Replaced legacy QR scanning analyzer/camera helper usage with CameraFrameProvider + DetectQrCodeUseCase in QrScannerFragment.
  • Updated QR scanning area targeting by computing bounds via GetBoundsRelativeToParentUseCase.
  • Simplified the login module’s dependencies by adding :infra:camera and removing direct QR-scanner-related libraries.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
feature/login/src/main/res/layout/fragment_qr_scanner.xml Adjusts QR overlay visibility/preview-related layout attributes.
feature/login/src/main/java/com/simprints/feature/login/screens/qrscanner/QrScannerFragment.kt Migrates QR scanning logic to CameraFrameProvider frames + DetectQrCodeUseCase.
feature/login/build.gradle.kts Switches dependencies to :infra:camera and removes direct CameraX/Barcode deps.

Comment thread feature/login/build.gradle.kts
Comment thread feature/login/src/main/res/layout/fragment_qr_scanner.xml Outdated
@luhmirin-s
luhmirin-s force-pushed the feature/MS-1498-frame-provider-login branch from 3d96189 to c43015f Compare August 6, 2026 14:17
@luhmirin-s
luhmirin-s force-pushed the feature/MS-1498-frame-provider-login branch from c43015f to 936f3e6 Compare August 10, 2026 12:44
@luhmirin-s
luhmirin-s force-pushed the feature/MS-1498-frame-provider-login branch from 936f3e6 to bbb8cc8 Compare August 11, 2026 07:20
@luhmirin-s
luhmirin-s force-pushed the feature/MS-1498-frame-provider-login branch from bbb8cc8 to 9f1e75e Compare August 11, 2026 08:49
@sonarqubecloud

Copy link
Copy Markdown

@luhmirin-s
luhmirin-s merged commit b31a1b3 into main Aug 11, 2026
14 checks passed
@luhmirin-s
luhmirin-s deleted the feature/MS-1498-frame-provider-login branch August 11, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants