MS-1498 Frame provider in login - #1771
Merged
luhmirin-s merged 1 commit intoAug 11, 2026
Merged
Conversation
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and
a lite review from Copilot
and removed request for
a team
August 6, 2026 12:53
luhmirin-s
changed the base branch from
main
to
feature/MS-1495-frame-provider-face-capture
August 6, 2026 12:53
There was a problem hiding this comment.
Pull request overview
This PR updates the Login feature’s QR scanner to use the new :infra:camera frame provider pipeline, moving QR detection into a post-processing use case to align with the newer camera architecture.
Changes:
- Replaced legacy QR scanning analyzer/camera helper usage with
CameraFrameProvider+DetectQrCodeUseCaseinQrScannerFragment. - Updated QR scanning area targeting by computing bounds via
GetBoundsRelativeToParentUseCase. - Simplified the login module’s dependencies by adding
:infra:cameraand removing direct QR-scanner-related libraries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| feature/login/src/main/res/layout/fragment_qr_scanner.xml | Adjusts QR overlay visibility/preview-related layout attributes. |
| feature/login/src/main/java/com/simprints/feature/login/screens/qrscanner/QrScannerFragment.kt | Migrates QR scanning logic to CameraFrameProvider frames + DetectQrCodeUseCase. |
| feature/login/build.gradle.kts | Switches dependencies to :infra:camera and removes direct CameraX/Barcode deps. |
luhmirin-s
force-pushed
the
feature/MS-1498-frame-provider-login
branch
from
August 6, 2026 14:17
3d96189 to
c43015f
Compare
luhmirin-s
force-pushed
the
feature/MS-1498-frame-provider-login
branch
from
August 10, 2026 12:44
c43015f to
936f3e6
Compare
luhmirin-s
force-pushed
the
feature/MS-1498-frame-provider-login
branch
from
August 11, 2026 07:20
936f3e6 to
bbb8cc8
Compare
luhmirin-s
force-pushed
the
feature/MS-1498-frame-provider-login
branch
from
August 11, 2026 08:49
bbb8cc8 to
9f1e75e
Compare
|
alexandr-simprints
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2026.3.0
Notable changes
Testing guidance
Additional work checklist