MS-1495 Use frame provider in face capture module - #1770
Merged
luhmirin-s merged 2 commits intoAug 11, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Migrates the face capture live feedback screen from direct CameraX ImageAnalysis usage to the shared CameraFrameProvider pipeline, delegating crop-to-target behavior to the new post-processing use case in :infra:camera.
Changes:
- Replace in-fragment CameraX setup / analyzer wiring with
CameraFrameProviderinitialisation andframescollection. - Delegate cropping from
CropToTargetOverlayAnalyzertoFrameCropToTargetUseCase(and remove the old analyzer + its test). - Update
face/capturemodule dependencies to include:infra:cameraand drop direct CameraX deps.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| face/capture/src/test/java/com/simprints/face/capture/screens/livefeedback/CropToTargetOverlayAnalyzerTest.kt | Removes tests for the deleted in-module cropping analyzer (cropping responsibility moved to infra use case). |
| face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackFragment.kt | Switches camera + frame processing to CameraFrameProvider and applies post-processing crop use case. |
| face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/CropToTargetOverlayAnalyzer.kt | Deletes the old CameraX analyzer-based cropping implementation. |
| face/capture/build.gradle.kts | Adds :infra:camera and removes direct CameraX dependencies. |
luhmirin-s
force-pushed
the
feature/MS-1495-frame-provider-face-capture
branch
from
August 6, 2026 11:00
c511c5d to
75920ec
Compare
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
August 6, 2026 11:05
luhmirin-s
force-pushed
the
feature/MS-1495-frame-provider-face-capture
branch
from
August 6, 2026 12:48
75920ec to
015b57f
Compare
luhmirin-s
force-pushed
the
feature/MS-1495-frame-provider-face-capture
branch
from
August 10, 2026 12:43
c1d57f4 to
9929b36
Compare
luhmirin-s
force-pushed
the
feature/MS-1495-frame-provider-face-capture
branch
from
August 11, 2026 07:20
9929b36 to
cb999cf
Compare
luhmirin-s
force-pushed
the
feature/MS-1495-frame-provider-face-capture
branch
from
August 11, 2026 08:49
cb999cf to
67ae1f7
Compare
|
alexandr-simprints
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


JIRA ticket
Will be released in: 20226.3.0
Notable changes
Testing guidance
Additional work checklist