Skip to content

MS-1495 Use frame provider in face capture module - #1770

Merged
luhmirin-s merged 2 commits into
feature/MS-1497-frame-provider-mfid-qrfrom
feature/MS-1495-frame-provider-face-capture
Aug 11, 2026
Merged

MS-1495 Use frame provider in face capture module#1770
luhmirin-s merged 2 commits into
feature/MS-1497-frame-provider-mfid-qrfrom
feature/MS-1495-frame-provider-face-capture

Conversation

@luhmirin-s

Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 20226.3.0

Notable changes

  • Migrating Face capture to the new camera frame provider.
  • Cropping has been delegated to post-processing use case.

Testing guidance

  • Testiny Face capture test cases. There should be no changes in UX.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the face capture live feedback screen from direct CameraX ImageAnalysis usage to the shared CameraFrameProvider pipeline, delegating crop-to-target behavior to the new post-processing use case in :infra:camera.

Changes:

  • Replace in-fragment CameraX setup / analyzer wiring with CameraFrameProvider initialisation and frames collection.
  • Delegate cropping from CropToTargetOverlayAnalyzer to FrameCropToTargetUseCase (and remove the old analyzer + its test).
  • Update face/capture module dependencies to include :infra:camera and drop direct CameraX deps.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
face/capture/src/test/java/com/simprints/face/capture/screens/livefeedback/CropToTargetOverlayAnalyzerTest.kt Removes tests for the deleted in-module cropping analyzer (cropping responsibility moved to infra use case).
face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackFragment.kt Switches camera + frame processing to CameraFrameProvider and applies post-processing crop use case.
face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/CropToTargetOverlayAnalyzer.kt Deletes the old CameraX analyzer-based cropping implementation.
face/capture/build.gradle.kts Adds :infra:camera and removes direct CameraX dependencies.

@luhmirin-s
luhmirin-s force-pushed the feature/MS-1495-frame-provider-face-capture branch from c511c5d to 75920ec Compare August 6, 2026 11:00
@luhmirin-s
luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team August 6, 2026 11:05
@luhmirin-s
luhmirin-s force-pushed the feature/MS-1495-frame-provider-face-capture branch from 75920ec to 015b57f Compare August 6, 2026 12:48
@luhmirin-s
luhmirin-s force-pushed the feature/MS-1495-frame-provider-face-capture branch from c1d57f4 to 9929b36 Compare August 10, 2026 12:43
@luhmirin-s
luhmirin-s force-pushed the feature/MS-1495-frame-provider-face-capture branch from 9929b36 to cb999cf Compare August 11, 2026 07:20
@luhmirin-s
luhmirin-s force-pushed the feature/MS-1495-frame-provider-face-capture branch from cb999cf to 67ae1f7 Compare August 11, 2026 08:49
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
77.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@luhmirin-s
luhmirin-s merged commit b31a1b3 into main Aug 11, 2026
12 of 14 checks passed
@luhmirin-s
luhmirin-s deleted the feature/MS-1495-frame-provider-face-capture branch August 11, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants