Skip to content

feat(wave): support independent corner radii - #8

Merged
rehmatsg merged 1 commit into
mainfrom
codex/wave-corner-radii
Nov 20, 2026
Merged

rehmatsg merged 1 commit into
mainfrom
codex/wave-corner-radii

Conversation

@rehmatsg

@rehmatsg rehmatsg commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Inset waves can take a different radius for each corner. Vance can give the paywall wave its sheet’s top corners and the device’s bottom corners.

Changes

  • Add DistortionWave.cornerRadii and pass it to the wave renderer. Default geometry and style still apply when the property is omitted.
  • Cover an inset wave with distinct corners, a live radius update, and fallback to a uniform radius.
  • Prepare the 0.4.0 release.

Testing

  • dart format --output=none --set-exit-if-changed .
  • flutter analyze --no-pub --fatal-infos
  • All 37 distortion-wave widget tests passed.
  • dart pub publish --dry-run reported zero warnings.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Devin Review


Summary by cubic

Adds DistortionWave.cornerRadii so inset surfaces can use different corner radii per corner, for example a paywall wave with the sheet's top corners and the device's bottom corners.

  • Explicit radii take precedence over display corners and WaveGlow.cornerRadius; omitting the property keeps existing geometry and style behavior.
  • Live radius updates repaint in place, with fallback to uniform radius when set to null.
  • Covers an inset wave with distinct corners, an in-place radius update, and fallback; bumps the release to 0.4.0 and updates docs.

Written for commit 9138f9d. Summary will update on new commits.

View guided diff Turn on auto-fix

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="lib/src/distortion_wave/distortion_wave.dart">

<violation number="1" location="lib/src/distortion_wave/distortion_wave.dart:154">
P3: This nullable property is missing `defaultValue: null`, unlike `source`, `style` and `progress` above it. Add it so unset radii are omitted from diagnostics output.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

DiagnosticsProperty<WaveSource>('source', source, defaultValue: null),
)
..add(EnumProperty<WaveType>('type', type, defaultValue: null))
..add(DiagnosticsProperty<BorderRadius>('cornerRadii', cornerRadii))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: This nullable property is missing defaultValue: null, unlike source, style and progress above it. Add it so unset radii are omitted from diagnostics output.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At lib/src/distortion_wave/distortion_wave.dart, line 154:

<comment>This nullable property is missing `defaultValue: null`, unlike `source`, `style` and `progress` above it. Add it so unset radii are omitted from diagnostics output.</comment>

<file context>
@@ -144,6 +151,7 @@ class DistortionWave extends StatefulWidget {
         DiagnosticsProperty<WaveSource>('source', source, defaultValue: null),
       )
       ..add(EnumProperty<WaveType>('type', type, defaultValue: null))
+      ..add(DiagnosticsProperty<BorderRadius>('cornerRadii', cornerRadii))
       ..add(DiagnosticsProperty<WaveStyle>('style', style, defaultValue: null))
       ..add(DoubleProperty('progress', progress, defaultValue: null));
</file context>
Suggested change
..add(DiagnosticsProperty<BorderRadius>('cornerRadii', cornerRadii))
..add(
DiagnosticsProperty<BorderRadius>(
'cornerRadii',
cornerRadii,
defaultValue: null,
),
)

@rehmatsg
rehmatsg merged commit ee31167 into main Nov 20, 2026
7 checks passed
@rehmatsg
rehmatsg deleted the codex/wave-corner-radii branch November 20, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant