[codex] support media srcset for lightbox - #164
Merged
Conversation
haltakov
marked this pull request as ready for review
June 25, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a direct optional
srcsetfield to media entries in the gallery schema and passes it through resolved theme data asimage.srcset. Themes then emit that value asdata-pswp-srcset, allowing PhotoSwipe to choose an appropriately sized full-size image instead of always loading the original.This keeps responsive lightbox image data as a sibling of
thumbnailon each media item, rather than introducing a separate nested lightbox schema.Companion app PR: https://github.com/SimplePhotoGallery/app/pull/189
Impact
srcsetstrings.srcsetfield.Validation
yarn workspace @simple-photo-gallery/common compileyarn workspace simple-photo-gallery compileyarn workspace simple-photo-gallery test lightbox-srcset.test.ts --runInBandyarn workspace simple-photo-gallery test smoke.test.ts --runInBand