Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 24.x
cache: "yarn"
cache-dependency-path: "yarn.lock"
registry-url: "https://registry.npmjs.org"
Expand All @@ -43,5 +43,3 @@ jobs:
publish: yarn release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Comment on lines 44 to 45

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Isolate OIDC publishing from the install step

With NPM_TOKEN removed here, publishing now relies on the job-wide id-token: write permission for npm trusted publishing. In this workflow, yarn install --immutable runs before changesets/action, so on a merged release PR where the package.json versions are not published yet, any dependency lifecycle script executed during install can request the same OIDC token and run npm publish from this trusted workflow before the intended release step. Please split publishing into a separate job/phase that gets id-token: write only after dependencies/build artifacts are prepared, or otherwise prevent install-time scripts from having publish-capable OIDC access.

Useful? React with 👍 / 👎.

NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_CONFIG_PROVENANCE: true
Loading