Skip to content

[codex] add CLI e2e tests - #158

Merged
haltakov merged 3 commits into
mainfrom
codex/add-cli-e2e-tests
Jun 13, 2026
Merged

[codex] add CLI e2e tests#158
haltakov merged 3 commits into
mainfrom
codex/add-cli-e2e-tests

Conversation

@haltakov

Copy link
Copy Markdown
Contributor

What changed

Adds a new Jest-based CLI end-to-end suite for the gallery package. The suite exercises real CLI commands against isolated temp directories and validates user-facing generated artifacts.

Coverage includes:

  • documented two-command quick start
  • current-working-directory defaults and short aliases
  • CDN --base-url and --thumbs-base-url rendering
  • recursive subgallery navigation and child gallery output
  • build scan, --no-scan, and --prune behavior
  • thumbnail config passed through real CLI flags
  • non-interactive safety guardrails for overwrites, photo copying, and clean --all
  • help output, invalid option handling, telemetry preference persistence
  • built dist CLI smoke including create-theme

Why

The existing tests cover many module-level and happy-path flows, but there were still CLI contract gaps around command parsing, defaults, generated HTML URLs, packaged output, and non-interactive behavior. These tests increase confidence that user workflows keep working and CLI changes do not silently break documented behavior.

Validation

  • yarn check
  • yarn test tests/cli-e2e.test.ts --runInBand
  • yarn test --runInBand

Final full test result: 16 suites passed, 156 tests passed.

@haltakov
haltakov marked this pull request as ready for review June 13, 2026 23:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ef48de21e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread gallery/tests/cli-e2e.test.ts Outdated
Comment thread gallery/tests/cli-e2e.test.ts
@haltakov
haltakov merged commit 9499a78 into main Jun 13, 2026
1 check passed
@haltakov
haltakov deleted the codex/add-cli-e2e-tests branch June 13, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant