Skip to content

Refactor CMake with JRL CMake Modules v2 - #437

Open
ahoarau wants to merge 252 commits into
Simple-Robotics:develfrom
ahoarau:jrl-next
Open

ahoarau wants to merge 252 commits into
Simple-Robotics:develfrom
ahoarau:jrl-next

Conversation

@ahoarau

@ahoarau ahoarau commented Dec 11, 2025 •

Copy link
Copy Markdown
Collaborator

⚠️DO NOT MERGE UNTIL jrl-umi3218/jrl-cmakemodules#798 is merged ⚠️

This PR is a full rewrite of the CMake files with the JRL CMake Modules v2.

  • Full rewrite of the CMake Files in modern CMake
  • Remove submodules: archives can now be used
  • Remove external libraries
  • c++17 minimum required
  • pixi support
  • 🚧 NIX CI is temporarily disabled
  • Fix Documentation links
  • Support for find_package components
find_package(proxsuite 0.7.1 CONFIG REQUIRED COMPONENTS proxsuite vectorized)

@ahoarau
ahoarau marked this pull request as draft December 11, 2025 16:39
@ahoarau
ahoarau force-pushed the jrl-next branch 2 times, most recently from bd8de6d to c36d61e Compare December 22, 2025 14:54

@jorisv jorisv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Comment thread .github/workflows/conda/environment.yml Outdated
Comment thread .github/workflows/ci-linux-osx-win-conda.yml Outdated
Comment thread bindings/python/proxsuite/__init__.py
Comment thread examples/python/CMakeLists.txt
Comment thread examples/cpp/CMakeLists.txt
Comment thread CMakeLists.txt
Comment thread CMakeLists.txt
Comment thread CMakeLists.txt
Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt
@ahoarau
ahoarau force-pushed the jrl-next branch 6 times, most recently from 930496b to e4a6dd2 Compare January 9, 2026 07:33
@ahoarau
ahoarau force-pushed the jrl-next branch 3 times, most recently from 9920160 to 7ce7cbf Compare January 23, 2026 16:09
@ahoarau
ahoarau force-pushed the jrl-next branch 2 times, most recently from f85e65e to e238efe Compare February 11, 2026 18:32
@ahoarau
ahoarau force-pushed the jrl-next branch 7 times, most recently from b2617af to b0388c0 Compare February 20, 2026 09:26
@ahoarau
ahoarau force-pushed the jrl-next branch 2 times, most recently from 7f6f202 to 3d05dbd Compare March 24, 2026 08:52
@ahoarau
ahoarau force-pushed the jrl-next branch 2 times, most recently from 28e0fd5 to b09f8a3 Compare April 16, 2026 11:14
@ahoarau
ahoarau force-pushed the jrl-next branch 2 times, most recently from a104370 to 93c8745 Compare May 11, 2026 20:36

@jorisv jorisv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running tests, following tests are failing on Linux with pixi:

         33 - proxsuite-test-cpp.dense_maros_meszaros (SEGFAULT)
         34 - proxsuite-test-cpp.vectorized.dense_maros_meszaros (SEGFAULT)
         35 - proxsuite-test-cpp.sparse_maros_meszaros (SEGFAULT)
         36 - proxsuite-test-cpp.vectorized.sparse_maros_meszaros (SEGFAULT)

Comment thread .github/workflows/ci-linux.yml Outdated
Comment thread .github/workflows/ci-linux.yml
Comment thread .github/workflows/ci-pixi.yml Outdated
Comment thread .github/workflows/ci-pixi.yml Outdated
Comment thread .github/workflows/ci-ros.yml Outdated
Comment thread bindings/python/proxsuite/__init__.py
Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
Comment thread pixi.toml
Comment thread .github/workflows/ci-pixi.yml Outdated
Comment thread CMakeLists.txt Outdated
@jorisv
jorisv dismissed stale reviews from nim65s and themself via cad3632 October 1, 2026 14:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants