fix(autorun): actually load default.env and honor RESULTS_DIR (FR-082) - #48
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
lib.sh documented loading config/default.env but never read it, so the baked-in tunables (STRESS_DURATION_SEC, MEMTESTER_PCT, RESULTS_DIR) were ignored. Source it from /run/sysrescue-config (falling back to /default.env), make RESULTS_DIR empty-by-default so autorun0's writable-partition logic applies, and have setup_results_dir honor an explicitly configured RESULTS_DIR with a /run/results fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48110.
autorun/lib.shdocumented loadingconfig/default.envbut never read it, so its tunables were ignored. It now sources the baked config from/run/sysrescue-config/default.env(or/default.env);RESULTS_DIRis empty-by-default sosetup_results_dir()still prefers the writable FAT32 partition, but an explicitly configuredRESULTS_DIRis honored, with a/run/resultsfallback if it can't be created.bash -n+ shellcheck clean. ⚠ Not run on real hardware (no SystemRescue boot here).