test: rename test-wipe-lib.sh to test_is_usb_device.sh (FR-096) - #46
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
tests/test-wipe-lib.sh and tests/test_wipe-lib.sh differed by one character but test different functions (is_usb_device vs detect_drive_type). Rename the hyphenated one to say what it covers.
Avicennasis
commented
Sep 13, 2026
Avicennasis
left a comment
Avicennasis
left a comment
Member
Author
There was a problem hiding this comment.
Reviewed exact head d5bdec9b84041385074fc383296fc3e69fbe6534. The rename is complete in the tree, executable mode is preserved, and the header now distinguishes this is_usb_device() coverage from the underscore-named detect_drive_type() test. The renamed test passed, as did the available test_autorun0, overwrite-rounds, setup-results-dir, and verify-wipe shell suites. git diff --check is clean and GitHub's checks are green.
No issue found. I could not run the separate .bats suite because bats is not installed in this environment; this PR does not alter that suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48088.
tests/test-wipe-lib.sh(hyphen) andtests/test_wipe-lib.sh(underscore) differ by one character, but they are not duplicates — they test different functions:test-wipe-lib.sh→is_usb_device()test_wipe-lib.sh→detect_drive_type()test_wipe-lib.bats→nist_method_for_type()There is no overlapping coverage, so nothing was merged; the misleading hyphen/underscore symmetry was the actual hazard. The hyphenated file is renamed to
test_is_usb_device.shand its header now says which function it covers.🤖 Generated with opencode