Conversation
Follows the file/class naming introduced upstream (ActiveStressNashPanfilov,
ActiveStressRegazzoni, ...):
- active_stress_land_niederer.{cpp,h} -> ActiveStressLandNiederer.{cpp,h}
- class LandNiederer -> ActiveStressLandNiederer
The XML model label ("LandNiederer") is unchanged.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
==========================================
+ Coverage 73.41% 73.53% +0.12%
==========================================
Files 269 272 +3
Lines 40337 40489 +152
Branches 6755 6759 +4
==========================================
+ Hits 29612 29775 +163
+ Misses 10482 10470 -12
- Partials 243 244 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
Implements #606, the Land Niederer active stress model for coupled electromechanics. The phenomenological model consists of 7 state variables that describe the unbound, pre-power and post-power stroke states, the Calcium-Troponin binding kinetics, and the cross-bridge distortions. Length-dependency is embedded in the equations as well as the final active tension computation which collects several state variables together.
Note: this PR is currently in a draft stage, waiting on the merging of PR #650.
Release Notes
Documentation
The Land Niederer active stress class has been given detailed Doxygen documentation. At a certain point, we should definitely add a user-guide style documentation for electromechanics akin to how electrophysiology ionic models are described in our documentation page.
Testing
A unit test following the twitch protocol described in
./tests/unitTests/active_stress_testswas created. A CI test using the same slab mesh files has also been included.Code of Conduct & Contributing Guidelines