Adopt SilverAssistWP coding standard + shared PHPStan configs - #3
Merged
miguelcolmenares merged 5 commits intoAug 17, 2026
Merged
Conversation
- Add silverassist/coding-standards and silverassist/wp-coding-standards to require-dev - Pin platform.php to 8.2.0 to match the declared floor - Swap phpcs.xml's WordPress-Extra block for SilverAssistWP (already excludes the PSR-4 filename rules this plugin was locally excluding) - Fix 24 mechanical @PARAM spacing violations surfaced by the stricter ruleset via phpcbf
- Add silverassist/coding-standards and silverassist/wp-coding-standards to require-dev - Pin platform.php to 8.2.0 to match the declared floor - Swap phpcs.xml's WordPress-Extra block for SilverAssistWP (already excludes the PSR-4 filename rules this plugin was locally excluding) - Fix 9 mechanical @PARAM spacing violations surfaced by the stricter ruleset via phpcbf
- Add silverassist/coding-standards and silverassist/wp-coding-standards to require-dev - Pin platform.php to 8.2.0 to match the declared floor - Collapse phpcs.xml's manually-declared WordPress-Extra/WordPress-Docs/allowances block down to SilverAssistWP, which already covers all of it (verified byte-identical phpcs output before/after)
Each sub-plugin already required silverassist/coding-standards and silverassist/wp-coding-standards as dev dependencies but only consumed szepeviktor/phpstan-wordpress from them directly, duplicating the shared level:8 + excludePaths baseline locally instead of composing it. Switches all three phpstan.neon files to include the shared base.neon from both packages, per the pattern established across the rest of the portfolio (nextjs-graphql-hooks, silver-assist-security). Verified with vendor/bin/phpstan analyse in each sub-plugin — identical results to before (contentful-tables and graphql-shortcode-support: 0 errors; community-listings: pre-existing 3 errors, unrelated to this change, reproduced on the prior config too). CI (.github/workflows/ci.yml) and scripts/ are left untouched — this monorepo's Makefile-driven, multi-plugin CI has no equivalent to the per-repo reusable quality-checks.yml workflow used elsewhere, matching the precedent set for acf-clone-fields and silver-assist-security. No push: this repo is blocked on GitHub write access.
WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase flagged $source->databaseId as needing snake_case — but databaseId is WPGraphQL's own property name on its Post model, not one we declare; renaming it would break the property access. Newly surfaced by the SilverAssistWP ruleset adopted in this branch (the prior phpcs.xml didn't enforce this sniff here). Verified: PHPCS clean in all 3 sub-plugins, PHPStan unchanged (community-listings' pre-existing 3 errors, contentful-tables and graphql-shortcode-support both 0).
miguelcolmenares
deleted the
feature/adopt-silverassist-coding-standards
branch
August 17, 2026 07:18
miguelcolmenares
added a commit
that referenced
this pull request
Aug 17, 2026
…ors (#4) Fix silently-swallowed CI failures + resolve pre-existing PHPStan errors (#4) - Resolved all 3 pre-existing PHPStan errors in community-listings via real refactors, no suppressions - Fixed Makefile phpcs/phpstan/install/install-dev/build targets to propagate failures across all sub-plugins instead of only the last one in the loop - Aligned make phpcs with CI's own --warning-severity=0 behavior - Backfilled CHANGELOG entries for #2 and #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SilverAssistWPPHPCS ruleset (in place of hand-rolledWordPress-Extra/WordPress-Docsblocks) in all three sub-plugins —community-listings,contentful-tables,graphql-shortcode-supportphpstan/base.neonfromsilverassist/coding-standardsandsilverassist/wp-coding-standardsin each sub-plugin'sphpstan.neon, replacing the locally-duplicated level:8 + excludePaths baseline@paramspacing violations the stricter ruleset surfaced (viaphpcbf) incontentful-tables(9) andcommunity-listings(24)platform.phpto8.2.0in each sub-plugin'scomposer.jsonto match the declared PHP floorPart of the portfolio-wide coding-standards rollout already merged in
contact-form-to-api,paubox-cf7,nextjs-graphql-hooks,leadcapture-form,leadgen-app-form,acf-clone-fields,silver-assist-post-revalidate, andsilver-assist-security.Verified
vendor/bin/phpstan analysein each sub-plugin: identical results before/after this change (contentful-tablesandgraphql-shortcode-support: 0 errors;community-listings: same pre-existing 3 errors, unrelated to this PR, reproduced on the prior config too)graphql-shortcode-support'sphpcs.xmlcollapse verified byte-identical PHPCS output before/afterDeliberately out of scope
.github/workflows/ci.ymlandscripts/are untouched — this monorepo's Makefile-driven, multi-plugin CI has no equivalent to the per-repo reusablequality-checks.ymlworkflow used elsewhere in the portfolio, matching the same precedent already set foracf-clone-fieldsandsilver-assist-security(both of which also kept their existing CI as-is).Test plan
composer installsucceeds in all 3 sub-plugins with the new dev dependenciescommunity-listings' pre-existing 3 PHPStan errors are unchanged frommain, not newly introduced