refactor: retire Express handler bridge for learning actions - #77
Merged
Conversation
Convert handlers/*.mjs to Fetch-style ({ request, user, json }), call them
directly from dispatchLearningAction, and delete express-bridge.mjs.
api/learning.mjs is now a thin wrapper around the same dispatcher.
Closes #76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production learning requests no longer go through an Express
(req, res)adapter.dispatchLearningActionnow calls Fetch-style handlers directly.handlers/*.mjsdefault export tohandler({ request, user, json }).shared/api/express-bridge.mjs.api/learning.mjsis a leftover local dispatcher that wraps the samedispatchLearningActionpath (no second Express handler stack)./api/learning?action=URLs,PUBLIC_NO_AUTH, and dispatcher 401s are unchanged. Auth-required handlers useuserfrom ctx; public actions (gaps,critique,understanding,tag) do not re-run ExpressrequireAuth.Closes #76
Converted handlers
activityartifactsconceptscritiquedrillselofeynmangapsimported-reviewsnotes(learning-notes.mjs)profileprojectsreview-masterytagunderstandingweeklyChecks
pnpm test— 479 passedpnpm typecheckpnpm docs:validate