Repository navigation
Measure open-position risk and cost-comparable curriculum benchmarks - #16
Merged
Merged
Conversation
SignalLayerLabs
marked this pull request as ready for review
October 20, 2026 06:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and evidence
Curriculum drawdown currently covers closed trades, so a later profitable exit can conceal an adverse open-position path. The price-only hold reference excludes execution costs and assumes full investment.
Change
Verification
Risk and rollback
This improves measurement, not model skill or demonstrated alpha. Costs/liquidity are modeled; hold is a cash-notional opening scenario and terminal sale is an estimate. Bar-close drawdown excludes intrabar losses. No dividends/carry/taxes or cross-currency aggregation. Revert this commit to remove optional reports/UI; immutable source, outcome and checkpoint identities remain intact. No schema migration.
Production PR15 is deployed at 8789d12, but useful curriculum learning is not yet verified: an observed scheduled event deferred before entering the worker for
resource_pressure, while its outer status was mislabeled completed. This PR preserves that guard; runtime resource diagnosis is separate and remains open.