Skip to content

fix(command): ensure all props are under css var & placeholder with correct color - #344

Merged
YounixM merged 1 commit into
mainfrom
chore/remove-tailwind-v2
Aug 7, 2026
Merged

fix(command): ensure all props are under css var & placeholder with correct color#344
YounixM merged 1 commit into
mainfrom
chore/remove-tailwind-v2

Conversation

@H4ad

@H4ad H4ad commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Changes:

  • Ensure any prop under css is under a css var
  • Change the default color of placeholder to --muted-foreground

@H4ad H4ad added the run-visual-testing Add to run the visual testing with Chromatic. label Aug 3, 2026
@github-actions github-actions Bot added update-visual-testing Tells the CI jobs to update the visual testing once lands to main. and removed run-visual-testing Add to run the visual testing with Chromatic. labels Aug 3, 2026
@YounixM

YounixM commented Aug 7, 2026

Copy link
Copy Markdown
Member

We should have a lint rule that variable overrides should be semantic tokens and not absolute tokens

As the consumer applications control this, we should have do and don't mentioned as part of storybook

@YounixM
YounixM merged commit 20abcb8 into main Aug 7, 2026
7 checks passed
@YounixM
YounixM deleted the chore/remove-tailwind-v2 branch August 7, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update-visual-testing Tells the CI jobs to update the visual testing once lands to main.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants