Repository navigation
Add PR visual diffs for components and application screens - #24
Merged
Merged
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


共有コンポーネントやアプリ画面を変更したPRで、mainとの差分をPR上で確認できるようにします。UI catalog全ストーリーとBooskiff・Emumetの代表14状態をPC・モバイルで撮影し、変更前・変更後・差分を gh pr comment --attach で直接添付します。
検証: Bunテスト48件(CIと同じBun 1.3.13)、strict TypeScript、actionlint、zizmorが成功。UI catalog52枚とアプリ画面28枚をブラウザーで撮影し、同じrevisionを繰り返した画像が一致することを確認しました。current側ドライバーによるmain側アプリの撮影も一致しました。
GitHub CIも成功し、両revisionで各80枚を撮影、Changed/New/Deleted=0・Passed=80を確認しました。gh --attachによる実投稿も検証済みです。
初回PRではworkflow_run投稿処理がmainに存在しないため、自動添付はマージ後に有効になります。Secret設定と導入PRのマージ後、同一repositoryの変更PRで実際の自動投稿を確認する必要があります。