Repository navigation
🐛 Fix consumer CI lint and update shared workflows - #63
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 75.47% 75.47%
=======================================
Files 232 232
Lines 27216 27216
=======================================
Hits 20542 20542
Misses 6674 6674 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ShuttlePub/workflowsconsumer CI checks Emumetmainwithcargo clippy --all-targets -- -D warnings. Emumet's own CI was pinned to older reusable workflows that did not lint test targets, so test-code warnings made all four consumer jobs fail.Changes
ShuttlePub/workflowsmain commit5be8e4cbb4f1f1616dc88316d469f3b13b059445.Verification
cargo clippy --workspace --all-targets -- -D warnings— passed with Rust 1.97.0.cargo fmt --all -- --check— passed.cargo test --quiet -p kernel -p application— passed (227 passed, 45 ignored).git diff --check— passed.The PR CI will verify the PostgreSQL, server, and coverage jobs. Once merged, the four
ShuttlePub/workflowsRenovate PR consumer runs can be rerun against the corrected Emumetmain.