Remove indexing enhancement#711
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
04-30-remove_indexing_enhancement
branch
from
133f77e to
a453b41
Compare
19 tasks
st0012
approved these changes
May 1, 2026
Member
st0012
left a comment
st0012
left a comment
There was a problem hiding this comment.
Feels like it could be quite a regression for some users. Hopefully we can bring back DSL extension soon 🤞
vinistock
changed the base branch from
04-30-migrate_rails_test_style_discovery_to_rubydex
to
graphite-base/711
vinistock
force-pushed
the
graphite-base/711
branch
from
10adf35 to
fe5728a
Compare
vinistock
force-pushed
the
04-30-remove_indexing_enhancement
branch
from
a453b41 to
cb163be
Compare
Member
Author
|
Yeah, it's definitely not ideal, but investing the time to design a way to handle DSLs with high performance and parallelism way pay off in the long run. |
vinistock
force-pushed
the
04-30-remove_indexing_enhancement
branch
from
cb163be to
6b1f3ac
Compare
Member
Author
Merge activity
|
Morriar
reviewed
May 1, 2026
Contributor
Morriar
left a comment
Morriar
left a comment
There was a problem hiding this comment.
Should we also update the documentation? https://shopify.github.io/ruby-lsp/rails-add-on.html#active-record-callbacks-validations-and-associations
Member
Author
|
Add-on documentation is a separate task in Shopify/rubydex#669 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are still exploring an efficient way of handling DSLs, such as things like
belongs_to,has_manyand so on.For now, let's remove the enhancement since we cannot provide the same exact API.